Filippo Giunchedi has submitted this change and it was merged. Change subject: Remove preheat_kernel_page_cache option ......................................................................
Remove preheat_kernel_page_cache option Somehow this old option slipped through in the update for 2.1.2. Cassandra will refuse to start if set. It does helpfully point out the offending option in its log instead of merely complaining but starting up. Looks like the school of 'be strict in what you accept'. Change-Id: Ifc3934f3420a7664d86ae73ddb4e54e49fc11fa4 --- M templates/cassandra.yaml.erb 1 file changed, 0 insertions(+), 6 deletions(-) Approvals: Filippo Giunchedi: Verified; Looks good to me, approved diff --git a/templates/cassandra.yaml.erb b/templates/cassandra.yaml.erb index 604cf31..b5ce977 100644 --- a/templates/cassandra.yaml.erb +++ b/templates/cassandra.yaml.erb @@ -764,9 +764,3 @@ # reducing overhead from the TCP protocol itself, at the cost of increasing # latency if you block for cross-datacenter responses. inter_dc_tcp_nodelay: false - -# Enable or disable kernel page cache preheating from contents of the key cache after compaction. -# When enabled it would preheat only first "page" (4KB) of each row to optimize -# for sequential access. Note: This could be harmful for fat rows, see CASSANDRA-4937 -# for further details on that topic. -preheat_kernel_page_cache: false -- To view, visit https://gerrit.wikimedia.org/r/190156 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ifc3934f3420a7664d86ae73ddb4e54e49fc11fa4 Gerrit-PatchSet: 1 Gerrit-Project: operations/puppet/cassandra Gerrit-Branch: master Gerrit-Owner: GWicke <[email protected]> Gerrit-Reviewer: Alexandros Kosiaris <[email protected]> Gerrit-Reviewer: Filippo Giunchedi <[email protected]> _______________________________________________ MediaWiki-commits mailing list [email protected] https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
