Physikerwelt has uploaded a new change for review.

  https://gerrit.wikimedia.org/r/190225

Change subject: Fix: FormulaInfo messes up revision and page id
......................................................................

Fix: FormulaInfo messes up revision and page id

Change-Id: Iee82ad92b38484c272a6fb7d2f4aab9f82766f98
---
M FormulaInfo.php
1 file changed, 3 insertions(+), 4 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/MathSearch 
refs/changes/25/190225/1

diff --git a/FormulaInfo.php b/FormulaInfo.php
index 0185ea0..887bf07 100644
--- a/FormulaInfo.php
+++ b/FormulaInfo.php
@@ -78,9 +78,8 @@
                $pageName = (string)$revision->getTitle();
                $out->addWikiText( "* Page found: [[$pageName#$eid|$pageName]] 
(eq $eid)  ", false );
                $out->addHtml( '<a href="/index.php?title=' . $pageName . 
'&action=purge&mathpurge=true">(force rerendering)</a>' );
-               $pid = Revision::newFromId($oldID)->getTitle()->getArticleID();
                /* @var $mo MathObject  */
-               $mo = MathObject::constructformpage( $pid, $eid );
+               $mo = MathObject::constructformpage( $oldID, $eid );
                if ( !$mo ) {
                        $out->addWikiText( 'Cannot find the equation data in 
the database.' );
                        return false;
@@ -99,6 +98,7 @@
                $this->DisplayRendering( $mo->getUserInputTex(), MW_MATH_PNG );
                $out->addWikiText( '==Similar pages==' );
                $out->addWikiText( 'Calculated based on the variables occurring 
on the entire ' . $pageName . ' page' );
+               $pid = Revision::newFromId($oldID)->getTitle()->getArticleID();
                $mo->findSimilarPages( $pid );
                $out->addWikiText( '==Variables==' );
                $mo->getObservations();
@@ -197,8 +197,7 @@
                                $out->addWikiText('SVG image empty. Force 
Re-Rendering' );
                                $renderer->render( true );
                        }
-                       $out->addWikiText( 'SVG (' . self::getlengh( 
$renderer->getSvg( 'render' ) ) . ') :',
-                               FALSE );
+                       $out->addWikiText( 'SVG (' . self::getlengh( 
$renderer->getSvg( 'render' ) ) . ') :', false );
                        $out->addHtml( $renderer->getSvg() ); // FALSE, 
'mwe-math-demo' ) );
                        $out->addHtml( "<br />\n" );
                }

-- 
To view, visit https://gerrit.wikimedia.org/r/190225
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Iee82ad92b38484c272a6fb7d2f4aab9f82766f98
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/MathSearch
Gerrit-Branch: master
Gerrit-Owner: Physikerwelt <w...@physikerwelt.de>

_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

Reply via email to