Esanders has uploaded a new change for review.
https://gerrit.wikimedia.org/r/190473
Change subject: Fix appearance of icons on disabled TextInputWidgets
......................................................................
Fix appearance of icons on disabled TextInputWidgets
Change-Id: I3618e4674128e825686ed2d0ecb951ac0c5790b7
---
M demos/pages/widgets.js
M src/styles/widgets/TextInputWidget.less
M src/themes/apex/widgets.less
M src/themes/mediawiki/widgets.less
4 files changed, 26 insertions(+), 0 deletions(-)
git pull ssh://gerrit.wikimedia.org:29418/oojs/ui refs/changes/73/190473/1
diff --git a/demos/pages/widgets.js b/demos/pages/widgets.js
index c13950e..1719dbc 100644
--- a/demos/pages/widgets.js
+++ b/demos/pages/widgets.js
@@ -707,6 +707,17 @@
}
),
new OO.ui.FieldLayout(
+ new OO.ui.TextInputWidget( {
+ icon: 'picture',
+ indicator: 'required',
+ disabled: true
+ } ),
+ {
+ label: 'TextInputWidget (icon,
indicator, disabled)\u200E',
+ align: 'top'
+ }
+ ),
+ new OO.ui.FieldLayout(
new OO.ui.TextInputWidget( {
placeholder: 'Placeholder' } ),
{
label: 'TextInputWidget
(placeholder)\u200E',
diff --git a/src/styles/widgets/TextInputWidget.less
b/src/styles/widgets/TextInputWidget.less
index 5937008..390e8ee 100644
--- a/src/styles/widgets/TextInputWidget.less
+++ b/src/styles/widgets/TextInputWidget.less
@@ -32,6 +32,13 @@
.oo-ui-unselectable();
}
+ &.oo-ui-widget-disabled {
+ > .oo-ui-iconElement-icon,
+ > .oo-ui-indicatorElement-indicator {
+ cursor: default;
+ }
+ }
+
&.oo-ui-labelElement > .oo-ui-labelElement-label {
display: block;
}
diff --git a/src/themes/apex/widgets.less b/src/themes/apex/widgets.less
index c124b6d..8519e56 100644
--- a/src/themes/apex/widgets.less
+++ b/src/themes/apex/widgets.less
@@ -247,6 +247,10 @@
border-color: #ddd;
background-color: #f3f3f3;
}
+ .oo-ui-iconElement-icon,
+ .oo-ui-indicatorElement-indicator {
+ opacity: 0.2;
+ }
}
&.oo-ui-pendingElement-pending {
diff --git a/src/themes/mediawiki/widgets.less
b/src/themes/mediawiki/widgets.less
index 7b8ed22..7ae7047 100644
--- a/src/themes/mediawiki/widgets.less
+++ b/src/themes/mediawiki/widgets.less
@@ -417,6 +417,10 @@
border-color: #ddd;
background-color: #f3f3f3;
}
+ .oo-ui-iconElement-icon,
+ .oo-ui-indicatorElement-indicator {
+ opacity: 0.2;
+ }
}
&.oo-ui-pendingElement-pending {
--
To view, visit https://gerrit.wikimedia.org/r/190473
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I3618e4674128e825686ed2d0ecb951ac0c5790b7
Gerrit-PatchSet: 1
Gerrit-Project: oojs/ui
Gerrit-Branch: master
Gerrit-Owner: Esanders <esand...@wikimedia.org>
_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
