jenkins-bot has submitted this change and it was merged.
Change subject: Make ImageGalleryBase member variables protected
......................................................................
Make ImageGalleryBase member variables protected
This was supposed to have happened in 1.24, but oh well.
Follows up 0804f31c1c116787f.
Change-Id: I1ff42f108d0955fd93e7ff7212cd5c1236cd944a
---
M includes/gallery/ImageGalleryBase.php
1 file changed, 6 insertions(+), 12 deletions(-)
Approvals:
Chad: Looks good to me, approved
jenkins-bot: Verified
diff --git a/includes/gallery/ImageGalleryBase.php
b/includes/gallery/ImageGalleryBase.php
index 2a888a5..c89c6b6 100644
--- a/includes/gallery/ImageGalleryBase.php
+++ b/includes/gallery/ImageGalleryBase.php
@@ -30,39 +30,33 @@
abstract class ImageGalleryBase extends ContextSource {
/**
* @var array Gallery images
- * @deprecated since 1.23 (was declared "var") and will be removed in
1.24
*/
- public $mImages;
+ protected $mImages;
/**
* @var bool Whether to show the filesize in bytes in categories
- * @deprecated since 1.23 (was declared "var") and will be removed in
1.24
*/
- public $mShowBytes;
+ protected $mShowBytes;
/**
* @var bool Whether to show the filename. Default: true
- * @deprecated since 1.23 (was declared "var") and will be removed in
1.24
*/
- public $mShowFilename;
+ protected $mShowFilename;
/**
* @var string Gallery mode. Default: traditional
- * @deprecated since 1.23 (was declared "var") and will be removed in
1.24
*/
- public $mMode;
+ protected $mMode;
/**
* @var bool|string Gallery caption. Default: false
- * @deprecated since 1.23 (was declared "var") and will be removed in
1.24
*/
- public $mCaption = false;
+ protected $mCaption = false;
/**
* @var bool Hide blacklisted images?
- * @deprecated since 1.23 (was declared "var") and will be removed in
1.24
*/
- public $mHideBadImages;
+ protected $mHideBadImages;
/**
* @var Parser Registered parser object for output callbacks
--
To view, visit https://gerrit.wikimedia.org/r/188613
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I1ff42f108d0955fd93e7ff7212cd5c1236cd944a
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/core
Gerrit-Branch: master
Gerrit-Owner: Legoktm <[email protected]>
Gerrit-Reviewer: Chad <[email protected]>
Gerrit-Reviewer: Siebrand <[email protected]>
Gerrit-Reviewer: jenkins-bot <>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
