Hoo man has submitted this change and it was merged.
Change subject: Rework deprecated code in TestChanges
......................................................................
Rework deprecated code in TestChanges
This avoids:
* type hinting against Entity,
* calling deprecated methods.
Change-Id: Id4aaee764c27b16fe346bb5a0337ce34bb8e6ce5
---
M lib/tests/phpunit/changes/TestChanges.php
1 file changed, 6 insertions(+), 9 deletions(-)
Approvals:
Hoo man: Looks good to me, approved
diff --git a/lib/tests/phpunit/changes/TestChanges.php
b/lib/tests/phpunit/changes/TestChanges.php
index fcadf65..d64249e 100644
--- a/lib/tests/phpunit/changes/TestChanges.php
+++ b/lib/tests/phpunit/changes/TestChanges.php
@@ -6,7 +6,6 @@
use Wikibase\ChangeRow;
use Wikibase\ChangesTable;
use Wikibase\DataModel\Claim\Claim;
-use Wikibase\DataModel\Entity\Entity;
use Wikibase\DataModel\Entity\Item;
use Wikibase\DataModel\Entity\ItemId;
use Wikibase\DataModel\Entity\Property;
@@ -15,6 +14,7 @@
use Wikibase\DataModel\Snak\PropertyNoValueSnak;
use Wikibase\DataModel\Statement\Statement;
use Wikibase\DataModel\Statement\StatementList;
+use Wikibase\DataModel\Term\FingerprintProvider;
use Wikibase\DiffChange;
use Wikibase\EntityChange;
use Wikibase\EntityFactory;
@@ -300,19 +300,16 @@
public static function getEntities() {
$entityList = array();
+ /** @var FingerprintProvider[] $entities */
$entities = array(
- Item::newEmpty(),
- Property::newFromType( 'string' ),
+ new Item( new ItemId( 'Q112' ) ),
+ new Property( new PropertyId( 'P112' ), null, 'string'
),
);
- /**
- * @var Entity $entity
- */
- foreach( $entities as $entity ) {
+ foreach ( $entities as $entity ) {
$entityList[] = $entity;
- $entity->setId( 112 );
- $entity->setLabel( 'ja', '\u30d3\u30fc\u30eb' );
+ $entity->getFingerprint()->setLabel( 'ja',
'\u30d3\u30fc\u30eb' );
$entityList[] = $entity;
}
--
To view, visit https://gerrit.wikimedia.org/r/189739
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Id4aaee764c27b16fe346bb5a0337ce34bb8e6ce5
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/Wikibase
Gerrit-Branch: master
Gerrit-Owner: Thiemo Mättig (WMDE) <[email protected]>
Gerrit-Reviewer: Aude <[email protected]>
Gerrit-Reviewer: Hoo man <[email protected]>
Gerrit-Reviewer: Jeroen De Dauw <[email protected]>
Gerrit-Reviewer: jenkins-bot <>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
