Deskana has uploaded a new change for review.
https://gerrit.wikimedia.org/r/190637
Change subject: Don't include article snippet in "Share as text" option
......................................................................
Don't include article snippet in "Share as text" option
Presently, selecting the "Share as text" option when you share something
and haven't actually highlighted any text will cause the auto-generated
snippet to be shared, which generates shares so big they can't even be shared
to Twitter.
This patch changes "Share as text" when you've got nothing hightlighted to
not attempt to share the default snippet. This should fix that issue for now,
until it's refined further.
Bug: T89541
Change-Id: Ic8c749d9207d7e28043ecba896a3c2326dd85a34
---
M wikipedia/View Controllers/ShareCard/WMFShareOptionsViewController.m
M wikipedia/en.lproj/Localizable.strings
2 files changed, 3 insertions(+), 10 deletions(-)
git pull ssh://gerrit.wikimedia.org:29418/apps/ios/wikipedia
refs/changes/37/190637/1
diff --git a/wikipedia/View
Controllers/ShareCard/WMFShareOptionsViewController.m b/wikipedia/View
Controllers/ShareCard/WMFShareOptionsViewController.m
index 239f37e..c108463 100644
--- a/wikipedia/View Controllers/ShareCard/WMFShareOptionsViewController.m
+++ b/wikipedia/View Controllers/ShareCard/WMFShareOptionsViewController.m
@@ -218,15 +218,8 @@
- (void)respondToTapForTextGesture: (UITapGestureRecognizer*) recognizer
{
- [self.delegate tappedShareCardWithText: self.snippet];
- if ([self.snippet isEqualToString:@""]) {
- self.shareTitle =
[MWLocalizedString(@"share-article-name-on-wikipedia", nil)
- stringByReplacingOccurrencesOfString:@"$1"
withString:self.shareTitle];
- } else {
- self.shareTitle =
[[MWLocalizedString(@"share-article-name-on-wikipedia-with-selected-text", nil)
- stringByReplacingOccurrencesOfString:@"$1"
withString:self.shareTitle]
- stringByReplacingOccurrencesOfString:@"$2"
withString:self.snippet];
- }
+ self.shareTitle = [MWLocalizedString(@"share-article-name-on-wikipedia",
nil)
+ stringByReplacingOccurrencesOfString:@"$1"
withString:self.shareTitle];
MWKImage *bestImage = self.article.image;
if (!bestImage) {
diff --git a/wikipedia/en.lproj/Localizable.strings
b/wikipedia/en.lproj/Localizable.strings
index 65e3048..9e9e8a2 100644
--- a/wikipedia/en.lproj/Localizable.strings
+++ b/wikipedia/en.lproj/Localizable.strings
@@ -191,7 +191,7 @@
"share-menu-page-saved-access" = "Tip: to access your saved pages, tap $1
above or long-press $2 below.";
"share-custom-menu-item" = "Share";
-"share-article-name-on-wikipedia" = "\"$1\" on @Wikipedia";
+"share-article-name-on-wikipedia" = "\"$1\" on @Wikipedia:";
"share-article-name-on-wikipedia-with-selected-text" = "\"$1\" on @Wikipedia:
\"$2\"";
"share-as-image" = "Share as image";
"share-as-text" = "Share as text";
--
To view, visit https://gerrit.wikimedia.org/r/190637
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ic8c749d9207d7e28043ecba896a3c2326dd85a34
Gerrit-PatchSet: 1
Gerrit-Project: apps/ios/wikipedia
Gerrit-Branch: master
Gerrit-Owner: Deskana <[email protected]>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
