[MediaWiki-commits] [Gerrit] fix for undefined index in setTaskPrioritySum - change (phabricator...Sprint)

[Christopher Johnson (WMDE) (Code Review)]

Christopher Johnson (WMDE) has submitted this change and it was merged.

Change subject: fix for undefined index in setTaskPrioritySum
......................................................................


fix for undefined index in setTaskPrioritySum

Change-Id: I6734128968ca6366ad38f31beaf27e591c48c319
---
M rsrc/behavior-priority-pie.js
M src/util/SprintPoints.php
2 files changed, 13 insertions(+), 6 deletions(-)

Approvals:
  Christopher Johnson (WMDE): Verified; Looks good to me, approved



diff --git a/rsrc/behavior-priority-pie.js b/rsrc/behavior-priority-pie.js
index ba49e66..a7264c0 100644
--- a/rsrc/behavior-priority-pie.js
+++ b/rsrc/behavior-priority-pie.js
@@ -23,4 +23,3 @@
         }
     });
 });
-
diff --git a/src/util/SprintPoints.php b/src/util/SprintPoints.php
index 20b2041..6c4f8f2 100644
--- a/src/util/SprintPoints.php
+++ b/src/util/SprintPoints.php
@@ -6,7 +6,7 @@
 private $task_open_status_sum;
 private $task_closed_status_sum;
 private $tasks;
-private $taskPrioritySum;
+private $taskPrioritySum = array();
 
   public function setTaskPoints ($taskpoints) {
     $this->taskpoints = $taskpoints;
@@ -85,16 +85,24 @@
     $priority_name = $this->getPriorityName($task);
     $points = $this->getTaskPoints($task->getPHID());
     if ($priority_name) {
-      $this->taskPrioritySum =
-          $this->setTaskPrioritySum($this->taskPrioritySum, $priority_name,
-              $points);
+      $this->taskPrioritySum = 
$this->setTaskPrioritySum($this->taskPrioritySum,
+          $priority_name,
+          $points);
     }
     return;
   }
 
   private function setTaskPrioritySum ($task_priority_sum, $priority_name,
                                       $points) {
-    $task_priority_sum[$priority_name] += $points;
+        if (empty($task_priority_sum)) {
+          $task_priority_sum[$priority_name] = $points;
+        } else {
+            if (isset($task_priority_sum[$priority_name])) {
+              $task_priority_sum[$priority_name] += $points;
+            } else {
+              $task_priority_sum[$priority_name] = $points;
+            }
+        }
     return $task_priority_sum;
   }
 

-- 
To view, visit https://gerrit.wikimedia.org/r/190659
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I6734128968ca6366ad38f31beaf27e591c48c319
Gerrit-PatchSet: 1
Gerrit-Project: phabricator/extensions/Sprint
Gerrit-Branch: master
Gerrit-Owner: Christopher Johnson (WMDE) <christopher.john...@wikimedia.de>
Gerrit-Reviewer: Christopher Johnson (WMDE) <christopher.john...@wikimedia.de>
Gerrit-Reviewer: jenkins-bot <>

_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits