Christopher Johnson (WMDE) has submitted this change and it was merged. Change subject: changes javelin_tag to phutil_tag for image ......................................................................
changes javelin_tag to phutil_tag for image using javelin_tag breaks the points counter Change-Id: I3c249121fdb62bdd4f3ca798f4b66bf6ef65bdd6 --- M src/view/SprintBoardTaskCard.php 1 file changed, 11 insertions(+), 11 deletions(-) Approvals: Christopher Johnson (WMDE): Verified; Looks good to me, approved diff --git a/src/view/SprintBoardTaskCard.php b/src/view/SprintBoardTaskCard.php index a6eb2b4..a017a01 100644 --- a/src/view/SprintBoardTaskCard.php +++ b/src/view/SprintBoardTaskCard.php @@ -94,12 +94,19 @@ ->setViewer($this->viewer); $task = $this->getTask(); $task_phid = $task->getPHID(); + $can_edit = $this->getCanEdit(); $this->points = $query->getStoryPointsForTask($task_phid); - $can_edit = $this->getCanEdit(); $color_map = ManiphestTaskPriority::getColorMap(); $bar_color = idx($color_map, $task->getPriority(), 'grey'); + + if (!(is_null($this->owner))) { + $label = $this->owner->getName(); + $ownerimage = $this->renderHandleIcon($this->owner, $label); + } else { + $ownerimage = null; + } $card = id(new PHUIObjectItemView()) ->setObjectName('T'.$task->getID()) @@ -122,15 +129,8 @@ ->setHref('/project/sprint/board/task/edit/'.$task->getID() .'/')) ->setBarColor($bar_color) - ->addAttribute($this->getCardAttributes()); - - if (!(is_null($this->owner))) { - $label = $this->owner->getName(); - $ownerimage = $this->renderHandleIcon($this->owner, $label); - } else { - $ownerimage = null; - } - $card->setImageIcon($ownerimage); + ->addAttribute($this->getCardAttributes()) + ->setImageIcon($ownerimage); return $card; } @@ -148,7 +148,7 @@ $options['meta'] = array('tip' => $label); } - return javelin_tag( + return phutil_tag( 'span', $options, ''); -- To view, visit https://gerrit.wikimedia.org/r/190752 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: merged Gerrit-Change-Id: I3c249121fdb62bdd4f3ca798f4b66bf6ef65bdd6 Gerrit-PatchSet: 1 Gerrit-Project: phabricator/extensions/Sprint Gerrit-Branch: master Gerrit-Owner: Christopher Johnson (WMDE) <christopher.john...@wikimedia.de> Gerrit-Reviewer: Christopher Johnson (WMDE) <christopher.john...@wikimedia.de> Gerrit-Reviewer: jenkins-bot <> _______________________________________________ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits