Bgerstle has uploaded a new change for review. https://gerrit.wikimedia.org/r/188583
Change subject: image gallery ...................................................................... image gallery - [x] show gallery w/ placeholders immediately, fetching metadata afterwards - [x] give visual indication that high-res has been downloaded - [x] nice UI to show description, copyright, & owner - [x] persist image info to save a round trip - [x] smarter caching for placholder & high-res images - [x] implement copyright -> glyph logic - [x] ensure that image info is deleted when articles are deleted offline - [x] make copyright a button that opens license URL - [x] cache high-res thumbnails in memory - [x] limit size of high-res gallery images Change-Id: I25deb84259cd9cd2028b7bd36bf0042b4b95acf4 --- D MediaWikiKit/MediaWikiKit.xcodeproj/project.pbxproj M MediaWikiKit/MediaWikiKit/MWKDataStore.h M MediaWikiKit/MediaWikiKit/MWKDataStore.m M MediaWikiKit/MediaWikiKit/MWKImage.h M MediaWikiKit/MediaWikiKit/MWKImage.m A MediaWikiKit/MediaWikiKit/MWKImageInfo+MWKImageComparison.h A MediaWikiKit/MediaWikiKit/MWKImageInfo+MWKImageComparison.m A MediaWikiKit/MediaWikiKit/MWKImageInfo.h A MediaWikiKit/MediaWikiKit/MWKImageInfo.m M MediaWikiKit/MediaWikiKit/MWKImageList.h M MediaWikiKit/MediaWikiKit/MWKImageList.m D MediaWikiKit/MediaWikiKit/MWKImageMetadata.h D MediaWikiKit/MediaWikiKit/MWKImageMetadata.m D MediaWikiKit/MediaWikiKit/MWKImageMetadataItem.h D MediaWikiKit/MediaWikiKit/MWKImageMetadataItem.m A MediaWikiKit/MediaWikiKit/MWKLicense.h A MediaWikiKit/MediaWikiKit/MWKLicense.m M MediaWikiKit/MediaWikiKit/MWKSite.h M MediaWikiKit/MediaWikiKit/MWKSite.m M MediaWikiKit/MediaWikiKit/MediaWikiKit.h D MediaWikiKit/MediaWikiKitTests/Info.plist A MediaWikiKit/MediaWikiKitTests/MWKImageInfo+MWKImageComparisonTests.m A MediaWikiKit/MediaWikiKitTests/MWKImageListTests.m M Wikipedia.xcodeproj/project.pbxproj A WikipediaUnitTests/CircularBitwiseRotationTests.m A WikipediaUnitTests/NSArray+BKIndexTests.m A WikipediaUnitTests/NSMutableDictionary+MaybeSetTests.m A WikipediaUnitTests/WMFErrorForApiErrorObjectTests.m A WikipediaUnitTests/WMFJoinedPropertyParametersTests.m M wikipedia/AppDelegate.m A wikipedia/Categories/AFHTTPRequestOperationManager+UniqueRequests.h A wikipedia/Categories/AFHTTPRequestOperationManager+UniqueRequests.m A wikipedia/Categories/MWKLicense+ToGlyph.h A wikipedia/Categories/MWKLicense+ToGlyph.m A wikipedia/Categories/NSArray+BKIndex.h A wikipedia/Categories/NSArray+BKIndex.m A wikipedia/Categories/NSMutableDictionary+WMFMaybeSet.h A wikipedia/Categories/NSMutableDictionary+WMFMaybeSet.m A wikipedia/Categories/NSString+HTMLParsing.h A wikipedia/Categories/NSString+HTMLParsing.m A wikipedia/Categories/UICollectionViewFlowLayout+NSCopying.h A wikipedia/Categories/UICollectionViewFlowLayout+NSCopying.m A wikipedia/Categories/UICollectionViewFlowLayout+WMFItemSizeThatFits.h A wikipedia/Categories/UICollectionViewFlowLayout+WMFItemSizeThatFits.m M wikipedia/Categories/UIFont+WMFStyle.m A wikipedia/Defines/WMF_FunUtilities.h A wikipedia/Defines/WMF_FunUtilities.m M wikipedia/Defines/WikiGlyph_Chars.h M wikipedia/Fonts/WikiFont-Glyphs.ttf M wikipedia/Networking/Fetchers/ArticleFetcher.m A wikipedia/Networking/Fetchers/MWKImageInfoFetcher.h A wikipedia/Networking/Fetchers/MWKImageInfoFetcher.m A wikipedia/Networking/Queues/AFHTTPRequestOperationManager+WMFConfig.h A wikipedia/Networking/Queues/AFHTTPRequestOperationManager+WMFConfig.m M wikipedia/Networking/Queues/QueuesSingleton.m A wikipedia/Networking/Serializers/MWKImageInfoResponseSerializer.h A wikipedia/Networking/Serializers/MWKImageInfoResponseSerializer.m A wikipedia/Networking/WMFNetworkUtilities.h A wikipedia/Networking/WMFNetworkUtilities.m A wikipedia/View Controllers/Image Gallery/WMFImageGalleryCollectionViewCell.h A wikipedia/View Controllers/Image Gallery/WMFImageGalleryCollectionViewCell.m A wikipedia/View Controllers/Image Gallery/WMFImageGalleryDetailOverlayView.h A wikipedia/View Controllers/Image Gallery/WMFImageGalleryDetailOverlayView.m A wikipedia/View Controllers/Image Gallery/WMFImageGalleryDetailOverlayView.xib A wikipedia/View Controllers/Image Gallery/WMFImageGalleryViewController.h A wikipedia/View Controllers/Image Gallery/WMFImageGalleryViewController.m M wikipedia/View Controllers/LeadImage/LeadImageContainer.h M wikipedia/View Controllers/LeadImage/LeadImageContainer.m M wikipedia/View Controllers/LeadImage/LeadImageContainer.xib A wikipedia/View Controllers/WebView/WebViewController+ImageGalleryPresentation.h A wikipedia/View Controllers/WebView/WebViewController+ImageGalleryPresentation.m M wikipedia/View Controllers/WebView/WebViewController.m A wikipedia/View Controllers/WebView/WebViewController_Private.h M www/js/bridge.js M www/js/listeners.js M www/package.json 76 files changed, 3,538 insertions(+), 1,420 deletions(-) git pull ssh://gerrit.wikimedia.org:29418/apps/ios/wikipedia refs/changes/83/188583/9 -- To view, visit https://gerrit.wikimedia.org/r/188583 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I25deb84259cd9cd2028b7bd36bf0042b4b95acf4 Gerrit-PatchSet: 9 Gerrit-Project: apps/ios/wikipedia Gerrit-Branch: master Gerrit-Owner: Bgerstle <bgers...@wikimedia.org> Gerrit-Reviewer: Bgerstle <bgers...@wikimedia.org> Gerrit-Reviewer: Brion VIBBER <br...@wikimedia.org> Gerrit-Reviewer: Dr0ptp4kt <ab...@wikimedia.org> Gerrit-Reviewer: Fjalapeno <cfl...@wikimedia.org> Gerrit-Reviewer: Mhurd <mh...@wikimedia.org> Gerrit-Reviewer: jenkins-bot <> _______________________________________________ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits