Thiemo Mättig (WMDE) has uploaded a new change for review.
https://gerrit.wikimedia.org/r/191659
Change subject: Make stuff in SpecialNewEntity private
......................................................................
Make stuff in SpecialNewEntity private
All this is not used outside of the class, according to PHPStorm.
Please double-check.
Change-Id: If544f98636a04a6e476cc9035e4991180352d97e
---
M repo/includes/specials/SpecialNewEntity.php
1 file changed, 7 insertions(+), 19 deletions(-)
git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/Wikibase
refs/changes/59/191659/1
diff --git a/repo/includes/specials/SpecialNewEntity.php
b/repo/includes/specials/SpecialNewEntity.php
index dcd4720..258ff9c 100644
--- a/repo/includes/specials/SpecialNewEntity.php
+++ b/repo/includes/specials/SpecialNewEntity.php
@@ -9,7 +9,6 @@
use Wikibase\DataModel\Entity\Entity;
use Wikibase\Repo\WikibaseRepo;
use Wikibase\Summary;
-use Wikibase\SummaryFormatter;
/**
* Page for creating new Wikibase entities.
@@ -33,12 +32,12 @@
/**
* @var string|null
*/
- protected $label = null;
+ private $label = null;
/**
* @var string|null
*/
- protected $description = null;
+ private $description = null;
/**
* @var Language
@@ -46,19 +45,14 @@
private $contentLanguage = null;
/**
- * @var SummaryFormatter
+ * @var string
*/
- protected $summaryFormatter;
+ private $rightsUrl;
/**
* @var string
*/
- protected $rightsUrl;
-
- /**
- * @var string
- */
- protected $rightsText;
+ private $rightsText;
/**
* @param string $name Name of the special page, as seen in links and
URLs.
@@ -180,8 +174,6 @@
}
/**
- * Create entity
- *
* @since 0.1
*
* @return Entity Created entity of correct subtype
@@ -273,12 +265,10 @@
/**
* Building the HTML form for creating a new item.
*
- * @since 0.1
- *
* @param string|null $legend initial value for the label input box
* @param string $additionalHtml initial value for the description
input box
*/
- public function createForm( $legend = null, $additionalHtml = '' ) {
+ private function createForm( $legend = null, $additionalHtml = '' ) {
$this->addCopyrightText();
$this->getOutput()->addHTML(
@@ -323,7 +313,7 @@
/**
* @todo could factor this out into a special page form builder and
renderer
*/
- protected function addCopyrightText() {
+ private function addCopyrightText() {
$copyrightView = new SpecialPageCopyrightView(
new CopyrightMessageBuilder(),
$this->rightsUrl,
@@ -336,8 +326,6 @@
}
/**
- * Get legend
- *
* @since 0.1
*
* @return string Legend for the fieldset
--
To view, visit https://gerrit.wikimedia.org/r/191659
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: If544f98636a04a6e476cc9035e4991180352d97e
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/Wikibase
Gerrit-Branch: master
Gerrit-Owner: Thiemo Mättig (WMDE) <[email protected]>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
