jenkins-bot has submitted this change and it was merged.
Change subject: Added "noime" class to site id input
......................................................................
Added "noime" class to site id input
Bug: T88417
Change-Id: I9212b4dd7b1868fa7acf92c57ed2a0277214bcb0
(cherry picked from commit a077e21825140b89f19461aa630d05ba262302e7)
---
M lib/resources/jquery.wikibase/jquery.wikibase.sitelinkview.js
1 file changed, 8 insertions(+), 5 deletions(-)
Approvals:
Hoo man: Looks good to me, approved
jenkins-bot: Verified
diff --git a/lib/resources/jquery.wikibase/jquery.wikibase.sitelinkview.js
b/lib/resources/jquery.wikibase/jquery.wikibase.sitelinkview.js
index 2b59c3c..bd270ca 100644
--- a/lib/resources/jquery.wikibase/jquery.wikibase.sitelinkview.js
+++ b/lib/resources/jquery.wikibase/jquery.wikibase.sitelinkview.js
@@ -247,10 +247,10 @@
}
}
- var $pageNameInput = $( '<input>', {
- placeholder: mw.msg(
'wikibase-sitelink-page-edit-placeholder' ),
- dir: dir
- } ).pagesuggester( pageNameInputOptions );
+ var $pageNameInput = $( '<input>' )
+ .attr( 'placeholder', mw.msg(
'wikibase-sitelink-page-edit-placeholder' ) )
+ .attr( 'dir', dir )
+ .pagesuggester( pageNameInputOptions );
var pagesuggester = $pageNameInput.data( 'pagesuggester' );
@@ -270,7 +270,10 @@
return;
}
- var $siteIdInput = $( '<input />' )
+ var $siteIdInput = $( '<input>' )
+ // FIXME: "noime" class prevents Universal Language
Selector's IME from being applied
+ // to the input element with the IME overlaying the
site suggestions (see T88417).
+ .addClass( 'noime' )
.attr( 'placeholder', mw.msg(
'wikibase-sitelink-site-edit-placeholder' ) )
.siteselector( {
source: self.options.getAllowedSites
--
To view, visit https://gerrit.wikimedia.org/r/191642
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I9212b4dd7b1868fa7acf92c57ed2a0277214bcb0
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/Wikibase
Gerrit-Branch: wmf/1.25wmf16
Gerrit-Owner: Hoo man <[email protected]>
Gerrit-Reviewer: Henning Snater <[email protected]>
Gerrit-Reviewer: Hoo man <[email protected]>
Gerrit-Reviewer: jenkins-bot <>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
