Wctaiwan has uploaded a new change for review.
https://gerrit.wikimedia.org/r/191845
Change subject: [WIP] Limit trigger for section anchors to text
......................................................................
[WIP] Limit trigger for section anchors to text
Make it so that only hovering over the header text itself triggers
section anchors, rather than anywhere on the line.
I need help with updating the parser tests.
Bug: T18691
Change-Id: I49aea8ffb8662b9c3e860b72cad77d33e9839d07
---
M includes/Linker.php
M resources/src/mediawiki/mediawiki.sectionAnchor.css
2 files changed, 3 insertions(+), 12 deletions(-)
git pull ssh://gerrit.wikimedia.org:29418/mediawiki/core
refs/changes/45/191845/1
diff --git a/includes/Linker.php b/includes/Linker.php
index ae8695b..2d11d1b 100644
--- a/includes/Linker.php
+++ b/includes/Linker.php
@@ -1751,6 +1751,7 @@
$link, $legacyAnchor = false
) {
$ret = "<h$level$attribs"
+ . "<span class=\"mw-headline-wrapper\">"
. Html::element( 'a',
array(
'href' => '#' . $anchor,
@@ -1760,6 +1761,7 @@
wfMessage( 'section-symbol' )->text()
)
. "<span class=\"mw-headline\"
id=\"$anchor\">$html</span>"
+ . "</span>"
. $link
. "</h$level>";
if ( $legacyAnchor !== false ) {
diff --git a/resources/src/mediawiki/mediawiki.sectionAnchor.css
b/resources/src/mediawiki/mediawiki.sectionAnchor.css
index 1a8fe0a..730f383 100644
--- a/resources/src/mediawiki/mediawiki.sectionAnchor.css
+++ b/resources/src/mediawiki/mediawiki.sectionAnchor.css
@@ -42,18 +42,7 @@
color: #000;
}
-.mw-body h1:hover .mw-headline-anchor,
-.mw-body h2:hover .mw-headline-anchor,
-.mw-body h3:hover .mw-headline-anchor,
-.mw-body h4:hover .mw-headline-anchor,
-.mw-body h5:hover .mw-headline-anchor,
-.mw-body h6:hover .mw-headline-anchor,
-.mw-body h1:focus .mw-headline-anchor,
-.mw-body h2:focus .mw-headline-anchor,
-.mw-body h3:focus .mw-headline-anchor,
-.mw-body h4:focus .mw-headline-anchor,
-.mw-body h5:focus .mw-headline-anchor,
-.mw-body h6:focus .mw-headline-anchor {
+.mw-headline-wrapper:hover .mw-headline-anchor {
filter: alpha(opacity=100);
opacity: 1;
}
--
To view, visit https://gerrit.wikimedia.org/r/191845
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I49aea8ffb8662b9c3e860b72cad77d33e9839d07
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/core
Gerrit-Branch: master
Gerrit-Owner: Wctaiwan <[email protected]>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
