Gerrit Patch Uploader has uploaded a new change for review.

  https://gerrit.wikimedia.org/r/191869

Change subject: mediawiki.special.preferences.js: Simplify modulo
......................................................................

mediawiki.special.preferences.js: Simplify modulo

See:
https://stackoverflow.com/questions/4467539/javascript-modulo-not-behaving

Change-Id: Id3efc7c7a1a57dcbb33ba1272ed5a20428ee6433
---
M resources/src/mediawiki.special/mediawiki.special.preferences.js
1 file changed, 2 insertions(+), 6 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/core 
refs/changes/69/191869/1

diff --git a/resources/src/mediawiki.special/mediawiki.special.preferences.js 
b/resources/src/mediawiki.special/mediawiki.special.preferences.js
index 2e660ce..6ea7501 100644
--- a/resources/src/mediawiki.special/mediawiki.special.preferences.js
+++ b/resources/src/mediawiki.special/mediawiki.special.preferences.js
@@ -223,12 +223,8 @@
                localTime = servertime + minuteDiff;
 
                // Bring time within the [0,1440) range.
-               while ( localTime < 0 ) {
-                       localTime += 1440;
-               }
-               while ( localTime >= 1440 ) {
-                       localTime -= 1440;
-               }
+               localTime = ( ( localTime % 1440 ) + 1440 ) % 1440;
+
                $localtimeHolder.text( mediaWiki.language.convertNumber( 
minutesToHours( localTime ) ) );
        }
 

-- 
To view, visit https://gerrit.wikimedia.org/r/191869
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Id3efc7c7a1a57dcbb33ba1272ed5a20428ee6433
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/core
Gerrit-Branch: master
Gerrit-Owner: Gerrit Patch Uploader <gerritpatchuploa...@gmail.com>

_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

Reply via email to