jenkins-bot has submitted this change and it was merged.
Change subject: Collection session: protect against 'enabled' key being unset
......................................................................
Collection session: protect against 'enabled' key being unset
Change-Id: I0055f0bdd873dd653b36aec698dcdcde29d97560
---
M Collection.session.php
1 file changed, 2 insertions(+), 1 deletion(-)
Approvals:
Aaron Schulz: Looks good to me, approved
jenkins-bot: Verified
diff --git a/Collection.session.php b/Collection.session.php
index c099a83..8e83ce0 100644
--- a/Collection.session.php
+++ b/Collection.session.php
@@ -80,7 +80,8 @@
* @return bool
*/
static function isEnabled() {
- return ( self::hasSession() &&
$_SESSION['wsCollection']['enabled'] );
+ return self::hasSession() && isset(
$_SESSION['wsCollection']['enabled'] ) &&
+ $_SESSION['wsCollection']['enabled'];
}
/**
--
To view, visit https://gerrit.wikimedia.org/r/192017
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I0055f0bdd873dd653b36aec698dcdcde29d97560
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/Collection
Gerrit-Branch: master
Gerrit-Owner: Chad <ch...@wikimedia.org>
Gerrit-Reviewer: Aaron Schulz <asch...@wikimedia.org>
Gerrit-Reviewer: Cscott <canan...@wikimedia.org>
Gerrit-Reviewer: jenkins-bot <>
_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
