Dduvall has uploaded a new change for review.
https://gerrit.wikimedia.org/r/192037
Change subject: Corrected Style/EmptyLineBetweenDefs RuboCop offenses
......................................................................
Corrected Style/EmptyLineBetweenDefs RuboCop offenses
Change-Id: I3a6e5137cdf9217f701b352fdf6eba93b747d496
---
M .rubocop_todo.yml
M lib/mediawiki_selenium/support/pages/login_page.rb
2 files changed, 1 insertion(+), 6 deletions(-)
git pull ssh://gerrit.wikimedia.org:29418/mediawiki/selenium
refs/changes/37/192037/1
diff --git a/.rubocop_todo.yml b/.rubocop_todo.yml
index 52ab5ea..9786a2a 100644
--- a/.rubocop_todo.yml
+++ b/.rubocop_todo.yml
@@ -6,12 +6,6 @@
# versions of RuboCop, may require this file to be generated again.
# Offense count: 1
-# Cop supports --auto-correct.
-# Configuration parameters: AllowAdjacentOneLineDefs.
-Style/EmptyLineBetweenDefs:
- Enabled: false
-
-# Offense count: 1
# Configuration parameters: Exclude.
Style/FileName:
Enabled: false
diff --git a/lib/mediawiki_selenium/support/pages/login_page.rb
b/lib/mediawiki_selenium/support/pages/login_page.rb
index f84b688..b070ecb 100644
--- a/lib/mediawiki_selenium/support/pages/login_page.rb
+++ b/lib/mediawiki_selenium/support/pages/login_page.rb
@@ -17,6 +17,7 @@
def logged_in_as_element
@browser.div(id: "mw-content-text").p.b
end
+
def login_with(username, password, wait_for_logout_element = true)
self.username_element.when_present.send_keys(username)
self.password_element.when_present.send_keys(password)
--
To view, visit https://gerrit.wikimedia.org/r/192037
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I3a6e5137cdf9217f701b352fdf6eba93b747d496
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/selenium
Gerrit-Branch: master
Gerrit-Owner: Dduvall <dduv...@wikimedia.org>
_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
