Robert Vogel has uploaded a new change for review. https://gerrit.wikimedia.org/r/192507
Change subject: NamespaceCombo: removed defaultValue ...................................................................... NamespaceCombo: removed defaultValue Apparently it is better to have no default value set. THIS CHANGE NEEDS TO BE CHERRYPICKED TO REL1_23! See also https://gerrit.wikimedia.org/r/#/c/191553/ Change-Id: I2cd1a114da77fcfbf24098ddb979b4eeb83a5392 (cherry picked from commit 72c33281c874ae645729e61f1984d1eddf02dd55) --- M resources/bluespice.extjs/BS/form/NamespaceCombo.js 1 file changed, 3 insertions(+), 4 deletions(-) git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/BlueSpiceFoundation refs/changes/07/192507/1 diff --git a/resources/bluespice.extjs/BS/form/NamespaceCombo.js b/resources/bluespice.extjs/BS/form/NamespaceCombo.js index 5c1680d..92bd189 100644 --- a/resources/bluespice.extjs/BS/form/NamespaceCombo.js +++ b/resources/bluespice.extjs/BS/form/NamespaceCombo.js @@ -6,9 +6,8 @@ queryMode: 'local', typeAhead: true, triggerAction: 'all', - value: 0, fieldLabel: mw.message('bs-extjs-label-namespace').plain(), - + //Custom Settings includeAll: false, excludeIds: [], @@ -21,10 +20,10 @@ this.callParent(arguments); }, - + setValue: function( value, doSelect ) { //In many cases we only know the namespace text and not the id. To make - //the life of us developers easier this litte snippet tries to convert + //the life of us developers easier this litte snippet tries to convert //from text to id. if( Ext.isString(value) ) { var normText = value.toLowerCase().replace(' ', '_'); -- To view, visit https://gerrit.wikimedia.org/r/192507 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I2cd1a114da77fcfbf24098ddb979b4eeb83a5392 Gerrit-PatchSet: 1 Gerrit-Project: mediawiki/extensions/BlueSpiceFoundation Gerrit-Branch: REL1_23 Gerrit-Owner: Robert Vogel <vo...@hallowelt.biz> _______________________________________________ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
