Aude has uploaded a new change for review.

  https://gerrit.wikimedia.org/r/192534

Change subject: Clarify comment in EntityViewPlaceholderExpander
......................................................................

Clarify comment in EntityViewPlaceholderExpander

regarding EntityRevisionLookup returning null

Change-Id: I75af47a53701c6f119ad6cf906a489a9c712cba1
---
M repo/includes/View/EntityViewPlaceholderExpander.php
1 file changed, 1 insertion(+), 1 deletion(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/Wikibase 
refs/changes/34/192534/1

diff --git a/repo/includes/View/EntityViewPlaceholderExpander.php 
b/repo/includes/View/EntityViewPlaceholderExpander.php
index d1f0892..dccee0e 100644
--- a/repo/includes/View/EntityViewPlaceholderExpander.php
+++ b/repo/includes/View/EntityViewPlaceholderExpander.php
@@ -252,7 +252,7 @@
                }
 
                if ( !$entityRev ) {
-                       // Could not load entity revision, $revisionId might be 
a non-entity revision
+                       // Could not load entity revision, entity might not 
exist for $entityId.
                        return '';
                }
 

-- 
To view, visit https://gerrit.wikimedia.org/r/192534
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I75af47a53701c6f119ad6cf906a489a9c712cba1
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/Wikibase
Gerrit-Branch: master
Gerrit-Owner: Aude <aude.w...@gmail.com>

_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

Reply via email to