Aude has submitted this change and it was merged. Change subject: Some cleanup in ExternalChangesList ......................................................................
Some cleanup in ExternalChangesList * titleTextFromEntityData now works with Entities not of type Item in all cases * $titleText is always defined before used (ie no longer a fatal in some cases) * added a fixme and todo * properly obtain a prefixed id (no need to construct an EntityObject) Change-Id: I019138b1b01623ca08f1b836c14dc3ccf49bbae5 --- M client/includes/ExternalChangesList.php 1 file changed, 21 insertions(+), 11 deletions(-) Approvals: Aude: Verified; Looks good to me, approved -- To view, visit https://gerrit.wikimedia.org/r/33171 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: merged Gerrit-Change-Id: I019138b1b01623ca08f1b836c14dc3ccf49bbae5 Gerrit-PatchSet: 1 Gerrit-Project: mediawiki/extensions/Wikibase Gerrit-Branch: master Gerrit-Owner: Jeroen De Dauw <jeroended...@gmail.com> Gerrit-Reviewer: Aude <aude.w...@gmail.com> _______________________________________________ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
