Filippo Giunchedi has uploaded a new change for review.
https://gerrit.wikimedia.org/r/192791
Change subject: graphite: do not aggregate counters by sum
......................................................................
graphite: do not aggregate counters by sum
we were instructing whisper to aggregate txstatsd counters by sum, which
doesn't match people's expectations. Counters are reset at each flush interval
so are rates by all intended purposes, thus aggregating by sum doesn't make
sense, we should aggregate by average instead (default).
Note this doesn't affect existing whisper files, only newly created files.
Existing files will need to be changes with whisper-resize.
Bug: T90111
Change-Id: I1377a79bfb25690f57775070988e346e54923d42
---
M manifests/role/graphite.pp
1 file changed, 0 insertions(+), 5 deletions(-)
git pull ssh://gerrit.wikimedia.org:29418/operations/puppet
refs/changes/91/192791/1
diff --git a/manifests/role/graphite.pp b/manifests/role/graphite.pp
index 706a567..7496ee6 100644
--- a/manifests/role/graphite.pp
+++ b/manifests/role/graphite.pp
@@ -56,11 +56,6 @@
xFilesFactor => 0.1,
aggregationMethod => 'max',
},
- 'sum' => {
- pattern => '\.count$',
- xFilesFactor => 0,
- aggregationMethod => 'sum',
- },
},
# All metric data goes through a single carbon-relay instance, which
--
To view, visit https://gerrit.wikimedia.org/r/192791
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I1377a79bfb25690f57775070988e346e54923d42
Gerrit-PatchSet: 1
Gerrit-Project: operations/puppet
Gerrit-Branch: production
Gerrit-Owner: Filippo Giunchedi <fgiunch...@wikimedia.org>
_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
