Jeroen De Dauw has submitted this change and it was merged.
Change subject: (Bug 36309) Introduce +sep= as a multiple value identifier in
#set
......................................................................
(Bug 36309) Introduce +sep= as a multiple value identifier in #set
## Description
Setting multiple values for the same property using the +sep= marker
in the #set parser function
|+sep= is a succeeding identifier that follows a property/value parameter
pair and is used to specifiy a separator by either using |+sep=; or in
case of an empty |+sep=/|+sep declaration, the comma is used as the default
separator.
## Example
{{#set:
|has set test 1=Example 1;Example 2;Example 3;Example 4|+sep=;
|has set test 2=More examples
|has set test 3=12+22+3+4+5+6+7+8+9+10|+sep=+
|has set test 4=In between example
|has set test 5=123,1234,12345,|+sep=
|has set test 6=One,or,two,more,examples|+sep
|has set test 6=Last example
}}
## Patch Set 6
+ Allows to define values as |Has property=Test1|Test2|Test3 equally to
the subobject parser funtion.
+ Add unit test
+ Remove all logic from the #set classs and transferred it into a separated
ParserParameter class
+ Move #set into SMW namespace
## Tests
OK (8 tests, 16 assertions)
Change-Id: Ia5b05ce8fcb21acc5d70d6dc283ebb79b118f6f5
---
M SemanticMediaWiki.hooks.php
M includes/SMW_Setup.php
A includes/parserhooks/ParserParameter.php
D includes/parserhooks/SMW_Set.php
A includes/parserhooks/Set.php
A tests/phpunit/includes/parserhooks/ParserParameterTest.php
6 files changed, 295 insertions(+), 44 deletions(-)
Approvals:
Mwjames: Verified
Jeroen De Dauw: Verified; Looks good to me, approved
--
To view, visit https://gerrit.wikimedia.org/r/32347
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ia5b05ce8fcb21acc5d70d6dc283ebb79b118f6f5
Gerrit-PatchSet: 6
Gerrit-Project: mediawiki/extensions/SemanticMediaWiki
Gerrit-Branch: 1.9.x
Gerrit-Owner: Mwjames <jamesin.hongkon...@gmail.com>
Gerrit-Reviewer: Jeroen De Dauw <jeroended...@gmail.com>
Gerrit-Reviewer: Markus Kroetzsch <mar...@semantic-mediawiki.org>
Gerrit-Reviewer: Mwjames <jamesin.hongkon...@gmail.com>
_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
