EBernhardson has uploaded a new change for review.
https://gerrit.wikimedia.org/r/193013
Change subject: Don't put serialized uuid's into the logging table
......................................................................
Don't put serialized uuid's into the logging table
Bug: T90745
Change-Id: I800ec8cf044e514b6b5d466343c54bfd1269a8f7
---
M includes/Log/PostModerationLogger.php
M tests/phpunit/api/ApiFlowModerateTopicTest.php
2 files changed, 3 insertions(+), 3 deletions(-)
git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/Flow
refs/changes/13/193013/1
diff --git a/includes/Log/PostModerationLogger.php
b/includes/Log/PostModerationLogger.php
index d096424..eed003e 100644
--- a/includes/Log/PostModerationLogger.php
+++ b/includes/Log/PostModerationLogger.php
@@ -52,9 +52,9 @@
$logParams = array();
if ( $post->isTopicTitle() ) {
- $logParams['topicId'] = $workflowId;
+ $logParams['topicId'] =
$workflowId->getAlphadecimal();
} else {
- $logParams['postId'] = $post->getRevisionId();
+ $logParams['postId'] =
$post->getRevisionId()->getAlphadecimal();
}
$this->logger->log(
diff --git a/tests/phpunit/api/ApiFlowModerateTopicTest.php
b/tests/phpunit/api/ApiFlowModerateTopicTest.php
index 7604e41..74779b9 100644
--- a/tests/phpunit/api/ApiFlowModerateTopicTest.php
+++ b/tests/phpunit/api/ApiFlowModerateTopicTest.php
@@ -56,6 +56,6 @@
$debug = json_encode( $data );
$logEntry = $data[0]['query']['logevents'][0];
$this->assertArrayHasKey( 'topicId', $logEntry, $debug );
- $this->assertEquals( $workflowId,
$logEntry['topicId']->getAlphadecimal(), $debug );
+ $this->assertEquals( $workflowId, $logEntry['topicId'], $debug
);
}
}
--
To view, visit https://gerrit.wikimedia.org/r/193013
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I800ec8cf044e514b6b5d466343c54bfd1269a8f7
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/Flow
Gerrit-Branch: master
Gerrit-Owner: EBernhardson <ebernhard...@wikimedia.org>
_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
