jenkins-bot has submitted this change and it was merged. Change subject: Setup browser tests ......................................................................
Setup browser tests * Create first test (redirect anonymous user going to Special:Gather) Change-Id: I2672d29de2ded8460d1b4d080720daaedb5a1e5c --- M Gemfile M Gemfile.lock A tests/browser/features/anonymous.feature A tests/browser/features/step_definitions/anonymous_steps.rb A tests/browser/features/support/env.rb A tests/browser/features/support/pages/gather_page.rb 6 files changed, 41 insertions(+), 50 deletions(-) Approvals: Jhernandez: Looks good to me, but someone else must approve Zfilipin: Looks good to me, approved jenkins-bot: Verified diff --git a/Gemfile b/Gemfile index 9122bd5..d180b78 100644 --- a/Gemfile +++ b/Gemfile @@ -3,7 +3,4 @@ source 'https://rubygems.org' -gem 'chunky_png' -gem 'jsduck' -gem 'mediawiki_selenium', '~> 0.3.2' -gem 'rubocop', require: false +gem 'mediawiki_selenium' diff --git a/Gemfile.lock b/Gemfile.lock index a382242..9b19502 100644 --- a/Gemfile.lock +++ b/Gemfile.lock @@ -1,29 +1,24 @@ GEM remote: https://rubygems.org/ specs: - ast (2.0.0) - astrolabe (1.3.0) - parser (>= 2.2.0.pre.3, < 3.0) builder (3.2.2) childprocess (0.5.5) ffi (~> 1.0, >= 1.0.11) - chunky_png (1.3.3) - cucumber (1.3.17) + cucumber (1.3.19) builder (>= 2.1.2) diff-lcs (>= 1.1.3) gherkin (~> 2.12) multi_json (>= 1.7.5, < 2.0) - multi_test (>= 0.1.1) + multi_test (>= 0.1.2) data_magic (0.20) faker (>= 1.1.2) yml_reader (>= 0.4) diff-lcs (1.2.5) - dimensions (1.2.0) - domain_name (0.5.22) + domain_name (0.5.23) unf (>= 0.0.5, < 1.0.0) faker (1.4.3) i18n (~> 0.5) - faraday (0.9.0) + faraday (0.9.1) multipart-post (>= 1.2, < 3) faraday-cookie_jar (0.0.6) faraday (>= 0.7.4) @@ -34,18 +29,12 @@ headless (1.0.2) http-cookie (1.0.2) domain_name (~> 0.5) - i18n (0.6.11) - jsduck (5.3.4) - dimensions (~> 1.2.0) - json (~> 1.8.0) - parallel (~> 0.7.1) - rdiscount (~> 2.1.6) - rkelly-remix (~> 0.0.4) - json (1.8.1) + i18n (0.7.0) + json (1.8.2) mediawiki_api (0.3.0) faraday (~> 0.9, >= 0.9.0) faraday-cookie_jar (~> 0.0, >= 0.0.6) - mediawiki_selenium (0.3.2) + mediawiki_selenium (0.4.2) cucumber (~> 1.3, >= 1.3.10) headless (~> 1.0, >= 1.0.1) json (~> 1.8, >= 1.8.1) @@ -56,42 +45,26 @@ syntax (~> 1.2, >= 1.2.0) mime-types (2.4.3) multi_json (1.10.1) - multi_test (0.1.1) + multi_test (0.1.2) multipart-post (2.0.0) - netrc (0.9.0) - page-object (1.0.2) + netrc (0.10.2) + page-object (1.0.3) page_navigation (>= 0.9) - selenium-webdriver (>= 2.42.0) - watir-webdriver (>= 0.6.9) + selenium-webdriver (>= 2.44.0) + watir-webdriver (>= 0.6.11) page_navigation (0.9) data_magic (>= 0.14) - parallel (0.7.1) - parser (2.2.0.pre.8) - ast (>= 1.1, < 3.0) - slop (~> 3.4, >= 3.4.5) - powerpack (0.0.9) - rainbow (2.0.0) - rdiscount (2.1.7.1) - rest-client (1.7.2) + rest-client (1.7.3) mime-types (>= 1.16, < 3.0) netrc (~> 0.7) - rkelly-remix (0.0.6) rspec-expectations (2.99.2) diff-lcs (>= 1.1.3, < 2.0) - rubocop (0.27.1) - astrolabe (~> 1.3) - parser (>= 2.2.0.pre.7, < 3.0) - powerpack (~> 0.0.6) - rainbow (>= 1.99.1, < 3.0) - ruby-progressbar (~> 1.4) - ruby-progressbar (1.7.0) - rubyzip (1.1.6) + rubyzip (1.1.7) selenium-webdriver (2.44.0) childprocess (~> 0.5) multi_json (~> 1.0) rubyzip (~> 1.0) websocket (~> 1.0) - slop (3.6.0) syntax (1.2.0) unf (0.1.4) unf_ext @@ -99,13 +72,10 @@ watir-webdriver (0.6.11) selenium-webdriver (>= 2.18.0) websocket (1.2.1) - yml_reader (0.4) + yml_reader (0.5) PLATFORMS ruby DEPENDENCIES - chunky_png - jsduck - mediawiki_selenium (~> 0.3.2) - rubocop + mediawiki_selenium diff --git a/tests/browser/features/anonymous.feature b/tests/browser/features/anonymous.feature new file mode 100644 index 0000000..0e2fd71 --- /dev/null +++ b/tests/browser/features/anonymous.feature @@ -0,0 +1,6 @@ +Feature: Anonymous users accessing private pages + + Scenario: + Given I am not logged in + When I visit the Gather page + Then I see the login page diff --git a/tests/browser/features/step_definitions/anonymous_steps.rb b/tests/browser/features/step_definitions/anonymous_steps.rb new file mode 100644 index 0000000..38cb3b3 --- /dev/null +++ b/tests/browser/features/step_definitions/anonymous_steps.rb @@ -0,0 +1,11 @@ +Given(/^I am not logged in$/) do +end + +When(/^I visit the Gather page$/) do + visit(GatherPage) +end + +Then(/^I see the login page$/) do + expect(@browser.url).to match(/Special\:UserLogin/) +end + diff --git a/tests/browser/features/support/env.rb b/tests/browser/features/support/env.rb new file mode 100644 index 0000000..c768f2f --- /dev/null +++ b/tests/browser/features/support/env.rb @@ -0,0 +1 @@ +require 'mediawiki_selenium' diff --git a/tests/browser/features/support/pages/gather_page.rb b/tests/browser/features/support/pages/gather_page.rb new file mode 100644 index 0000000..18f40bc --- /dev/null +++ b/tests/browser/features/support/pages/gather_page.rb @@ -0,0 +1,6 @@ +class GatherPage + include PageObject + include URL + + page_url URL.url('Special:Gather') +end -- To view, visit https://gerrit.wikimedia.org/r/191083 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: merged Gerrit-Change-Id: I2672d29de2ded8460d1b4d080720daaedb5a1e5c Gerrit-PatchSet: 4 Gerrit-Project: mediawiki/extensions/Gather Gerrit-Branch: master Gerrit-Owner: Jhernandez <jhernan...@wikimedia.org> Gerrit-Reviewer: Cmcmahon <cmcma...@wikimedia.org> Gerrit-Reviewer: Dduvall <dduv...@wikimedia.org> Gerrit-Reviewer: Jhernandez <jhernan...@wikimedia.org> Gerrit-Reviewer: Zfilipin <zfili...@wikimedia.org> Gerrit-Reviewer: jenkins-bot <> _______________________________________________ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
