Aude has uploaded a new change for review.
https://gerrit.wikimedia.org/r/193275
Change subject: Add more @group Database tags to repo tests
......................................................................
Add more @group Database tags to repo tests
These tests interact invoke Message::parse, which
in turn during parse, may access Title object and
LinkCache, depending on what other extensions one
has enabled. This means these tests may involve
database access and should have the @group tag.
Change-Id: I34a32acf353527471284aa2ba12afe1273cb5b5d
---
M repo/tests/phpunit/includes/Diff/ClaimDifferenceVisualizerTest.php
M repo/tests/phpunit/includes/ItemDisambiguationTest.php
M repo/tests/phpunit/includes/OutputPageJsConfigBuilderTest.php
M repo/tests/phpunit/includes/SummaryFormatterTest.php
M repo/tests/phpunit/includes/View/EntityViewPlaceholderExpanderTest.php
M repo/tests/phpunit/includes/View/SiteLinksViewTest.php
M repo/tests/phpunit/includes/api/ApiErrorReporterTest.php
M repo/tests/phpunit/includes/specials/SpecialMyLanguageFallbackChainTest.php
M repo/tests/phpunit/includes/specials/SpecialPageCopyrightViewTest.php
9 files changed, 14 insertions(+), 8 deletions(-)
git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/Wikibase
refs/changes/75/193275/1
diff --git a/repo/tests/phpunit/includes/Diff/ClaimDifferenceVisualizerTest.php
b/repo/tests/phpunit/includes/Diff/ClaimDifferenceVisualizerTest.php
index 99b78f0..b23ef39 100644
--- a/repo/tests/phpunit/includes/Diff/ClaimDifferenceVisualizerTest.php
+++ b/repo/tests/phpunit/includes/Diff/ClaimDifferenceVisualizerTest.php
@@ -27,6 +27,7 @@
* @group Wikibase
* @group WikibaseRepo
* @group WikibaseClaim
+ * @group Database
*
* @licence GNU GPL v2+
* @author Adam Shorland
diff --git a/repo/tests/phpunit/includes/ItemDisambiguationTest.php
b/repo/tests/phpunit/includes/ItemDisambiguationTest.php
index 4b988ca..4b56f23 100644
--- a/repo/tests/phpunit/includes/ItemDisambiguationTest.php
+++ b/repo/tests/phpunit/includes/ItemDisambiguationTest.php
@@ -2,8 +2,6 @@
namespace Wikibase\Test;
-use MediaWikiTestCase;
-use PHPUnit_Framework_TestCase;
use Wikibase\DataModel\Entity\Item;
use Wikibase\DataModel\Entity\ItemId;
use Wikibase\ItemDisambiguation;
@@ -16,11 +14,12 @@
* @group WikibaseRepo
* @group SpecialPage
* @group WikibaseSpecialPage
+ * @group Database
*
* @licence GNU GPL v2+
* @author Daniel Kinzler
*/
-class ItemDisambiguationTest extends PHPUnit_Framework_TestCase {
+class ItemDisambiguationTest extends \MediaWikiTestCase {
/**
* @param string $searchLanguageCode
diff --git a/repo/tests/phpunit/includes/OutputPageJsConfigBuilderTest.php
b/repo/tests/phpunit/includes/OutputPageJsConfigBuilderTest.php
index 321e267..4298d0c 100644
--- a/repo/tests/phpunit/includes/OutputPageJsConfigBuilderTest.php
+++ b/repo/tests/phpunit/includes/OutputPageJsConfigBuilderTest.php
@@ -12,11 +12,12 @@
*
* @group WikibaseRepo
* @group Wikibase
+ * @group Database
*
* @licence GNU GPL v2+
* @author Katie Filbert < aude.w...@gmail.com >
*/
-class OutputPageJsConfigBuilderTest extends \PHPUnit_Framework_TestCase {
+class OutputPageJsConfigBuilderTest extends \MediaWikiTestCase {
/**
* @dataProvider buildProvider
diff --git a/repo/tests/phpunit/includes/SummaryFormatterTest.php
b/repo/tests/phpunit/includes/SummaryFormatterTest.php
index 7735c7e..a3f8e08 100644
--- a/repo/tests/phpunit/includes/SummaryFormatterTest.php
+++ b/repo/tests/phpunit/includes/SummaryFormatterTest.php
@@ -22,6 +22,7 @@
* @group Wikibase
* @group WikibaseRepo
* @group WikibaseSummary
+ * @group Database
*
* @licence GNU GPL v2+
* @author John Erling Blad < jeb...@gmail.com >
diff --git
a/repo/tests/phpunit/includes/View/EntityViewPlaceholderExpanderTest.php
b/repo/tests/phpunit/includes/View/EntityViewPlaceholderExpanderTest.php
index 4a536bf..af9f6f7 100644
--- a/repo/tests/phpunit/includes/View/EntityViewPlaceholderExpanderTest.php
+++ b/repo/tests/phpunit/includes/View/EntityViewPlaceholderExpanderTest.php
@@ -27,6 +27,7 @@
* @group Wikibase
* @group WikibaseRepo
* @group EntityView
+ * @group Database
*
* @licence GNU GPL v2+
* @author Daniel Kinzler
diff --git a/repo/tests/phpunit/includes/View/SiteLinksViewTest.php
b/repo/tests/phpunit/includes/View/SiteLinksViewTest.php
index 3c2a13b..f438262 100644
--- a/repo/tests/phpunit/includes/View/SiteLinksViewTest.php
+++ b/repo/tests/phpunit/includes/View/SiteLinksViewTest.php
@@ -3,8 +3,6 @@
namespace Wikibase\Test;
use MediaWikiSite;
-use MediaWikiTestCase;
-use PHPUnit_Framework_TestCase;
use SiteList;
use Wikibase\DataModel\Entity\EntityId;
use Wikibase\DataModel\Entity\Item;
@@ -26,12 +24,13 @@
*
* @group Wikibase
* @group WikibaseRepo
+ * @group Database
*
* @licence GNU GPL v2+
* @author Adrian Lang <adrian.l...@wikimedia.de>
* @author Bene* < benestar.wikime...@gmail.com >
*/
-class SiteLinksViewTest extends PHPUnit_Framework_TestCase {
+class SiteLinksViewTest extends \MediaWikiTestCase {
/**
* @dataProvider getHtmlProvider
diff --git a/repo/tests/phpunit/includes/api/ApiErrorReporterTest.php
b/repo/tests/phpunit/includes/api/ApiErrorReporterTest.php
index aba77b2..8458a42 100644
--- a/repo/tests/phpunit/includes/api/ApiErrorReporterTest.php
+++ b/repo/tests/phpunit/includes/api/ApiErrorReporterTest.php
@@ -19,6 +19,7 @@
* @group Wikibase
* @group WikibaseValidators
* @group WikibaseAPI
+ * @group Database
*
* @licence GNU GPL v2+
* @author Daniel Kinzler
diff --git
a/repo/tests/phpunit/includes/specials/SpecialMyLanguageFallbackChainTest.php
b/repo/tests/phpunit/includes/specials/SpecialMyLanguageFallbackChainTest.php
index d80ac8e..d9e2a66 100644
---
a/repo/tests/phpunit/includes/specials/SpecialMyLanguageFallbackChainTest.php
+++
b/repo/tests/phpunit/includes/specials/SpecialMyLanguageFallbackChainTest.php
@@ -11,6 +11,7 @@
* @group WikibaseRepo
* @group SpecialPage
* @group WikibaseSpecialPage
+ * @group Database
*
* @licence GNU GPL v2+
*/
diff --git
a/repo/tests/phpunit/includes/specials/SpecialPageCopyrightViewTest.php
b/repo/tests/phpunit/includes/specials/SpecialPageCopyrightViewTest.php
index c3cc2b4..ef49af9 100644
--- a/repo/tests/phpunit/includes/specials/SpecialPageCopyrightViewTest.php
+++ b/repo/tests/phpunit/includes/specials/SpecialPageCopyrightViewTest.php
@@ -10,11 +10,13 @@
* @covers Wikibase\Repo\Specials\SpecialPageCopyrightView
*
* @group Wikibase
+ * @group WikibaseRepo
+ * @group Database
*
* @licence GNU GPL v2+
* @author Katie Filbert < aude.w...@gmail.com >
*/
-class SpecialPageCopyrightViewTest extends \PHPUnit_Framework_TestCase {
+class SpecialPageCopyrightViewTest extends \MediaWikiTestCase {
/**
* @dataProvider getHtmlProvider
--
To view, visit https://gerrit.wikimedia.org/r/193275
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I34a32acf353527471284aa2ba12afe1273cb5b5d
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/Wikibase
Gerrit-Branch: master
Gerrit-Owner: Aude <aude.w...@gmail.com>
_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
