Jdlrobson has uploaded a new change for review.
https://gerrit.wikimedia.org/r/193297
Change subject: Do not load css via JavaScript
......................................................................
Do not load css via JavaScript
All styles just be loaded in a link tag at top of page.
addModules always forces them to load via JavaScript
addModuleStyles doesn't allow dependencies so move those into the special
page.
Change-Id: Ie1b2c026b45869dd84c7d5dbac76699e1b9688b6
---
M includes/Resources.php
M includes/specials/SpecialGather.php
2 files changed, 6 insertions(+), 6 deletions(-)
git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/Gather
refs/changes/97/193297/1
diff --git a/includes/Resources.php b/includes/Resources.php
index 07c419a..7524dac 100644
--- a/includes/Resources.php
+++ b/includes/Resources.php
@@ -67,11 +67,6 @@
'styles' => array(
'ext.gather.styles/collections.less',
),
- 'dependencies' => array(
- 'mediawiki.ui.anchor',
- 'mediawiki.ui.icon',
- 'ext.gather.icons',
- ),
'position' => 'top',
'group' => 'other',
),
diff --git a/includes/specials/SpecialGather.php
b/includes/specials/SpecialGather.php
index 074535a..db4ffb3 100644
--- a/includes/specials/SpecialGather.php
+++ b/includes/specials/SpecialGather.php
@@ -106,7 +106,12 @@
$out = $this->getOutput();
$this->setHeaders();
$out->setProperty( 'unstyledContent', true );
- $out->addModules( array( 'ext.gather.styles' ) );
+ $out->addModuleStyles( array(
+ 'mediawiki.ui.anchor',
+ 'mediawiki.ui.icon',
+ 'ext.gather.icons',
+ 'ext.gather.styles',
+ ) );
$out->setPageTitle( $view->getTitle() );
$view->render( $out );
}
--
To view, visit https://gerrit.wikimedia.org/r/193297
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ie1b2c026b45869dd84c7d5dbac76699e1b9688b6
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/Gather
Gerrit-Branch: master
Gerrit-Owner: Jdlrobson <jrob...@wikimedia.org>
_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
