jenkins-bot has submitted this change and it was merged.
Change subject: Prevent form submission in FragmentInspector
......................................................................
Prevent form submission in FragmentInspector
This was previously prevented by FormLayout itself, but
Ie84826c7 in oojs-ui broke that.
Change-Id: Id7417f75685ac0dd1a6f81ad7f97727b27f650c3
---
M src/ui/inspectors/ve.ui.FragmentInspector.js
1 file changed, 3 insertions(+), 2 deletions(-)
Approvals:
Bartosz Dziewoński: Looks good to me, approved
jenkins-bot: Verified
diff --git a/src/ui/inspectors/ve.ui.FragmentInspector.js
b/src/ui/inspectors/ve.ui.FragmentInspector.js
index c76a717..b1d5071 100644
--- a/src/ui/inspectors/ve.ui.FragmentInspector.js
+++ b/src/ui/inspectors/ve.ui.FragmentInspector.js
@@ -40,10 +40,11 @@
/**
* Handle form submit events.
*
- * @method
+ * @param {jQuery.Event} e Submit event
*/
-ve.ui.FragmentInspector.prototype.onFormSubmit = function () {
+ve.ui.FragmentInspector.prototype.onFormSubmit = function ( e ) {
this.close( { action: 'done' } );
+ e.preventDefault();
};
/**
--
To view, visit https://gerrit.wikimedia.org/r/193494
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Id7417f75685ac0dd1a6f81ad7f97727b27f650c3
Gerrit-PatchSet: 2
Gerrit-Project: VisualEditor/VisualEditor
Gerrit-Branch: master
Gerrit-Owner: Catrope <roan.katt...@gmail.com>
Gerrit-Reviewer: Bartosz Dziewoński <matma....@gmail.com>
Gerrit-Reviewer: jenkins-bot <>
_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
