Krinkle has uploaded a new change for review.

  https://gerrit.wikimedia.org/r/193582

Change subject: installer: Remove unused references to 
wgResourceLoaderMaxQueryLength
......................................................................

installer: Remove unused references to wgResourceLoaderMaxQueryLength

* Added in 40e18e45343.
* Removed in 648bed9f839.

The latter left the Installer::values array still populating this
variable eventhough it was no longer used in the generators output.

The example in overrides.php is also outdated as modifying this
variable there would have no effect.

Change-Id: I0c86e94a004c034702c5fcd83257c0f4c3d15a57
---
M includes/installer/Installer.php
M includes/installer/LocalSettingsGenerator.php
M mw-config/overrides.php
3 files changed, 2 insertions(+), 3 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/core 
refs/changes/82/193582/1

diff --git a/includes/installer/Installer.php b/includes/installer/Installer.php
index 1036dcd..91195e9 100644
--- a/includes/installer/Installer.php
+++ b/includes/installer/Installer.php
@@ -186,7 +186,6 @@
                'wgUseInstantCommons',
                'wgUpgradeKey',
                'wgDefaultSkin',
-               'wgResourceLoaderMaxQueryLength',
        );
 
        /**
diff --git a/includes/installer/LocalSettingsGenerator.php 
b/includes/installer/LocalSettingsGenerator.php
index c0ba300..8724e0d 100644
--- a/includes/installer/LocalSettingsGenerator.php
+++ b/includes/installer/LocalSettingsGenerator.php
@@ -63,7 +63,7 @@
                                'wgRightsText', 'wgMainCacheType', 
'wgEnableUploads',
                                'wgMainCacheType', '_MemCachedServers', 
'wgDBserver', 'wgDBuser',
                                'wgDBpassword', 'wgUseInstantCommons', 
'wgUpgradeKey', 'wgDefaultSkin',
-                               'wgMetaNamespace', 
'wgResourceLoaderMaxQueryLength', 'wgLogo',
+                               'wgMetaNamespace', 'wgLogo',
                        ),
                        $db->getGlobalNames()
                );
diff --git a/mw-config/overrides.php b/mw-config/overrides.php
index 5758152..40b3dde 100644
--- a/mw-config/overrides.php
+++ b/mw-config/overrides.php
@@ -38,7 +38,7 @@
 class MyLocalSettingsGenerator extends LocalSettingsGenerator {
        function getText() {
                // Modify an existing setting
-               $this->values['wgResourceLoaderMaxQueryLength'] = 512;
+               $this->values['wgDefaultSkin'] = 'vector';
                // add a new setting
                $ls = parent::getText();
                return $ls . "\n\$wgUseTex = true;\n";

-- 
To view, visit https://gerrit.wikimedia.org/r/193582
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I0c86e94a004c034702c5fcd83257c0f4c3d15a57
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/core
Gerrit-Branch: master
Gerrit-Owner: Krinkle <krinklem...@gmail.com>

_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

Reply via email to