Ejegg has uploaded a new change for review.
https://gerrit.wikimedia.org/r/193856
Change subject: Only need one check for is_dir
......................................................................
Only need one check for is_dir
It implicitly includes file_exists test.
Change-Id: I25a6e609801455f2102d14035900248192e49f39
---
M includes/GlobalFunctions.php
1 file changed, 1 insertion(+), 1 deletion(-)
git pull ssh://gerrit.wikimedia.org:29418/mediawiki/core
refs/changes/56/193856/1
diff --git a/includes/GlobalFunctions.php b/includes/GlobalFunctions.php
index 5232413..7377433 100644
--- a/includes/GlobalFunctions.php
+++ b/includes/GlobalFunctions.php
@@ -2558,7 +2558,7 @@
wfDebug( "$caller: called wfMkdirParents($dir)\n" );
}
- if ( strval( $dir ) === '' || ( file_exists( $dir ) && is_dir( $dir ) )
) {
+ if ( strval( $dir ) === '' || is_dir( $dir ) ) {
return true;
}
--
To view, visit https://gerrit.wikimedia.org/r/193856
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I25a6e609801455f2102d14035900248192e49f39
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/core
Gerrit-Branch: master
Gerrit-Owner: Ejegg <eeggles...@wikimedia.org>
_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
