Jason.ji has uploaded a new change for review.
https://gerrit.wikimedia.org/r/194862
Change subject: One-line change to remove PHP Strict Standards warning about
'only variables should be passed by reference'.
......................................................................
One-line change to remove PHP Strict Standards warning about 'only variables
should be passed by reference'.
Change-Id: I0df07ef26233128a9b58043425287d8650e55ec0
---
M ApiGetTitleIcons.php
1 file changed, 2 insertions(+), 1 deletion(-)
git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/VikiTitleIcon
refs/changes/62/194862/1
diff --git a/ApiGetTitleIcons.php b/ApiGetTitleIcons.php
index 93df067..051acea 100644
--- a/ApiGetTitleIcons.php
+++ b/ApiGetTitleIcons.php
@@ -84,7 +84,8 @@
$api->execute();
$data = $api->getResultData();
- $key = array_shift( array_keys( $data["query"]["pages"]
) );
+ $keys = array_keys( $data['query']['pages'] );
+ $key = array_shift( $keys );
$url =
$data["query"]["pages"][$key]["imageinfo"][0]["url"];
$titleIconURLs[] = $url;
}
--
To view, visit https://gerrit.wikimedia.org/r/194862
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I0df07ef26233128a9b58043425287d8650e55ec0
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/VikiTitleIcon
Gerrit-Branch: master
Gerrit-Owner: Jason.ji <j...@mitre.org>
_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
