Umherirrender has uploaded a new change for review. https://gerrit.wikimedia.org/r/195102
Change subject: [schema] Make column page_props.pp_page an unsigned int ...................................................................... [schema] Make column page_props.pp_page an unsigned int The primary key of the page table is an unsigned int, the column page_props.pp_page refer the id and should have the same typ to store the same values as the page table does. No pre-deployment activity necessary; no need to sync deployment and merge; can be done at any time (now or later) Change-Id: Ie052a2ef1e41600b13f4bc00d2ac9e9bca78501f --- M includes/installer/MysqlUpdater.php A maintenance/archives/patch-page-props-pppage-unsigned.sql M maintenance/tables.sql 3 files changed, 4 insertions(+), 1 deletion(-) git pull ssh://gerrit.wikimedia.org:29418/mediawiki/core refs/changes/02/195102/1 diff --git a/includes/installer/MysqlUpdater.php b/includes/installer/MysqlUpdater.php index eef4334..1845cf6 100644 --- a/includes/installer/MysqlUpdater.php +++ b/includes/installer/MysqlUpdater.php @@ -274,6 +274,8 @@ 'patch-user-newtalk-userid-unsigned.sql' ), array( 'modifyFieldToUnsignedInt', 'user_properties', 'up_user', 'patch-user-properties-upuser-unsigned.sql' ), + array( 'modifyFieldToUnsignedInt', 'page_props', 'pp_page', + 'patch-page-props-pppage-unsigned.sql' ), ); } diff --git a/maintenance/archives/patch-page-props-pppage-unsigned.sql b/maintenance/archives/patch-page-props-pppage-unsigned.sql new file mode 100644 index 0000000..1fcce18 --- /dev/null +++ b/maintenance/archives/patch-page-props-pppage-unsigned.sql @@ -0,0 +1 @@ +ALTER TABLE /*_*/page_props MODIFY pp_page int unsigned NOT NULL; diff --git a/maintenance/tables.sql b/maintenance/tables.sql index 2396cdf..12c3c61 100644 --- a/maintenance/tables.sql +++ b/maintenance/tables.sql @@ -1424,7 +1424,7 @@ -- Name/value pairs indexed by page_id CREATE TABLE /*_*/page_props ( - pp_page int NOT NULL, + pp_page int unsigned NOT NULL, pp_propname varbinary(60) NOT NULL, pp_value blob NOT NULL, pp_sortkey float DEFAULT NULL -- To view, visit https://gerrit.wikimedia.org/r/195102 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: newchange Gerrit-Change-Id: Ie052a2ef1e41600b13f4bc00d2ac9e9bca78501f Gerrit-PatchSet: 1 Gerrit-Project: mediawiki/core Gerrit-Branch: master Gerrit-Owner: Umherirrender <umherirrender_de...@web.de> _______________________________________________ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits