jenkins-bot has submitted this change and it was merged. Change subject: Don't force #p-lang to show using jQuery.fn.show ......................................................................
Don't force #p-lang to show using jQuery.fn.show It's a performance anti-pattern; see <https://github.com/jquery/jquery.com/issues/88#issuecomment-72400007> Change-Id: If6e521c27975f7d64932268fde5778aa63fd08ee --- M resources/js/ext.uls.interface.js 1 file changed, 2 insertions(+), 2 deletions(-) Approvals: Santhosh: Looks good to me, approved jenkins-bot: Verified diff --git a/resources/js/ext.uls.interface.js b/resources/js/ext.uls.interface.js index 265fa48..86d17e7 100644 --- a/resources/js/ext.uls.interface.js +++ b/resources/js/ext.uls.interface.js @@ -315,8 +315,8 @@ $pLang = $( '#p-lang' ); // Add an element near the interlanguage links header $ulsTrigger = $( '<span>' ).addClass( 'uls-settings-trigger' ); - // Append ULS cog to languages section, but make sure it is visible. - $pLang.show().prepend( $ulsTrigger ); + // Append ULS cog to languages section. + $pLang.prepend( $ulsTrigger ); // Take care of any other elements with this class. $ulsTrigger = $( '.uls-settings-trigger' ); // Remove the dummy link, which was added to make sure that the section appears -- To view, visit https://gerrit.wikimedia.org/r/195077 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: merged Gerrit-Change-Id: If6e521c27975f7d64932268fde5778aa63fd08ee Gerrit-PatchSet: 1 Gerrit-Project: mediawiki/extensions/UniversalLanguageSelector Gerrit-Branch: master Gerrit-Owner: Ori.livneh <o...@wikimedia.org> Gerrit-Reviewer: Santhosh <santhosh.thottin...@gmail.com> Gerrit-Reviewer: jenkins-bot <> _______________________________________________ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
