jenkins-bot has submitted this change and it was merged.
Change subject: Souce selector: Let checkForTitle resolve false when title is
empty
......................................................................
Souce selector: Let checkForTitle resolve false when title is empty
It was rejecting and the 'done' handler in check method was not called.
Bug: T91629
Change-Id: Ia0ad90d3ddd7d0cab984c183b9c381ca37bc44e9
---
M modules/source/ext.cx.source.selector.js
1 file changed, 1 insertion(+), 1 deletion(-)
Approvals:
Nikerabbit: Looks good to me, approved
jenkins-bot: Verified
diff --git a/modules/source/ext.cx.source.selector.js
b/modules/source/ext.cx.source.selector.js
index a00948e..a12fda3 100644
--- a/modules/source/ext.cx.source.selector.js
+++ b/modules/source/ext.cx.source.selector.js
@@ -388,7 +388,7 @@
// Short circuit empty titles
if ( title === '' ) {
- return $.Deferred().reject().promise();
+ return $.Deferred().resolve( false ).promise();
}
// Reject titles with pipe in the name, as it has special
meaning in the api
--
To view, visit https://gerrit.wikimedia.org/r/195203
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ia0ad90d3ddd7d0cab984c183b9c381ca37bc44e9
Gerrit-PatchSet: 2
Gerrit-Project: mediawiki/extensions/ContentTranslation
Gerrit-Branch: master
Gerrit-Owner: Santhosh <santhosh.thottin...@gmail.com>
Gerrit-Reviewer: Nikerabbit <niklas.laxst...@gmail.com>
Gerrit-Reviewer: Santhosh <santhosh.thottin...@gmail.com>
Gerrit-Reviewer: jenkins-bot <>
_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
