Hello Ottomata,
I'd like you to do a code review. Please visit
https://gerrit.wikimedia.org/r/195261
to review the following change.
Change subject: Stop shifting twice when passing --rebuild-jar to script that
runs all guards
......................................................................
Stop shifting twice when passing --rebuild-jar to script that runs all guards
There is already a shift after the case, so the switch inside the
"--rebuild-jar" handling code is not needed
Change-Id: I40a08431a91368665c976c5ba9aca138c23ab22e
---
M guard/run_all_guards.sh
1 file changed, 0 insertions(+), 1 deletion(-)
git pull ssh://gerrit.wikimedia.org:29418/analytics/refinery/source
refs/changes/61/195261/1
diff --git a/guard/run_all_guards.sh b/guard/run_all_guards.sh
index f0aa856..389a5ca 100755
--- a/guard/run_all_guards.sh
+++ b/guard/run_all_guards.sh
@@ -29,7 +29,6 @@
case "$ARGUMENT" in
"--rebuild-jar" )
REBUILD_JAR=yes
- shift
;;
"--help" )
print_help
--
To view, visit https://gerrit.wikimedia.org/r/195261
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I40a08431a91368665c976c5ba9aca138c23ab22e
Gerrit-PatchSet: 1
Gerrit-Project: analytics/refinery/source
Gerrit-Branch: master
Gerrit-Owner: QChris <christ...@quelltextlich.at>
Gerrit-Reviewer: Ottomata <o...@wikimedia.org>
_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
