Mooeypoo has uploaded a new change for review.

  https://gerrit.wikimedia.org/r/195320

Change subject: Icon width should only be applied if there is an icon
......................................................................

Icon width should only be applied if there is an icon

Only apply icon styling (and in particular icon width/height)
if there is an actual icon set.

Change-Id: I5d3b38efa3995928447bc4dfc806b7f2f90ef2a0
---
M src/themes/apex/widgets.less
M src/themes/mediawiki/widgets.less
2 files changed, 2 insertions(+), 2 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/oojs/ui refs/changes/20/195320/1

diff --git a/src/themes/apex/widgets.less b/src/themes/apex/widgets.less
index 04a979d..638ae70 100644
--- a/src/themes/apex/widgets.less
+++ b/src/themes/apex/widgets.less
@@ -387,7 +387,7 @@
                width: @indicator-size;
        }
 
-       .oo-ui-iconElement-icon {
+       &.oo-ui-iconElement .oo-ui-iconElement-icon {
                width: @icon-size;
                left: 0.5em;
        }
diff --git a/src/themes/mediawiki/widgets.less 
b/src/themes/mediawiki/widgets.less
index b3e7c4f..3ae4dab 100644
--- a/src/themes/mediawiki/widgets.less
+++ b/src/themes/mediawiki/widgets.less
@@ -533,7 +533,7 @@
                height: 100%;
        }
 
-       .oo-ui-iconElement-icon {
+       &.oo-ui-iconElement .oo-ui-iconElement-icon {
                width: @icon-size;
                left: 0.5em;
        }

-- 
To view, visit https://gerrit.wikimedia.org/r/195320
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I5d3b38efa3995928447bc4dfc806b7f2f90ef2a0
Gerrit-PatchSet: 1
Gerrit-Project: oojs/ui
Gerrit-Branch: master
Gerrit-Owner: Mooeypoo <mor...@gmail.com>

_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

Reply via email to