TheDJ has submitted this change and it was merged. Change subject: (bug 2865) Add lang attribute to firstHeading ......................................................................
(bug 2865) Add lang attribute to firstHeading Adds a lang attribute to <h1 id="firstHeading">. Interface language is applied to <html> and content language is applied to <div id="mw-content-text">. This leaves firstHeading with the interface language, which is wrong in general. It also causes incorrect display of the title for languages that have custom line-height. This patch is based on code written by Munirathnam M at the Bangalore DevCamp (he couldn't submit it because of network issues). It looks OK to me, but it's my first time doing anything with $this->data in a skin, so please correct me if I'm wrong. Change-Id: I55dd392dbf0d4f768344b66e6ceb3a023b1d5c9b --- M RELEASE-NOTES-1.21 M skins/Modern.php M skins/MonoBook.php M skins/Vector.php 4 files changed, 14 insertions(+), 3 deletions(-) Approvals: TheDJ: Verified; Looks good to me, approved -- To view, visit https://gerrit.wikimedia.org/r/33163 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: merged Gerrit-Change-Id: I55dd392dbf0d4f768344b66e6ceb3a023b1d5c9b Gerrit-PatchSet: 7 Gerrit-Project: mediawiki/core Gerrit-Branch: master Gerrit-Owner: Amire80 <amir.ahar...@mail.huji.ac.il> Gerrit-Reviewer: Amire80 <amir.ahar...@mail.huji.ac.il> Gerrit-Reviewer: Nikerabbit <niklas.laxst...@gmail.com> Gerrit-Reviewer: Siebrand <siebr...@wikimedia.org> Gerrit-Reviewer: TheDJ <hartman.w...@gmail.com> Gerrit-Reviewer: Waldir <wal...@email.com> Gerrit-Reviewer: jenkins-bot _______________________________________________ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
