jenkins-bot has submitted this change and it was merged.
Change subject: [FIX] socketIO: Use older version to support WMF
......................................................................
[FIX] socketIO: Use older version to support WMF
The WMF is using socket.io 0.9 but the newest version of socketIO_client
(0.6.1) supports only socket.io 1.0. That causes a 404 error and makes
it unusuable. Use the latest version which still support 0.9. See also
T91393.
Bug: T85716
Change-Id: Icf10f7f907baaf346ad1e37400685853e4d774fe
---
M setup.py
1 file changed, 2 insertions(+), 1 deletion(-)
Approvals:
John Vandenberg: Looks good to me, approved
jenkins-bot: Verified
diff --git a/setup.py b/setup.py
index 744405e..274cdc2 100644
--- a/setup.py
+++ b/setup.py
@@ -27,7 +27,8 @@
'IRC': [irc_dep],
'mwparserfromhell': ['mwparserfromhell>=0.3.3'],
'Tkinter': ['Pillow'],
- 'rcstream': ['socketIO-client'],
+ # 0.6.1 supports socket.io 1.0, but WMF is using 0.9 (T91393 and T85716)
+ 'rcstream': ['socketIO-client<0.6.1'],
}
if sys.version_info[0] == 2:
--
To view, visit https://gerrit.wikimedia.org/r/195537
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Icf10f7f907baaf346ad1e37400685853e4d774fe
Gerrit-PatchSet: 1
Gerrit-Project: pywikibot/core
Gerrit-Branch: master
Gerrit-Owner: XZise <commodorefabia...@gmx.de>
Gerrit-Reviewer: John Vandenberg <jay...@gmail.com>
Gerrit-Reviewer: Ladsgroup <ladsgr...@gmail.com>
Gerrit-Reviewer: Merlijn van Deen <valhall...@arctus.nl>
Gerrit-Reviewer: jenkins-bot <>
_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
