Aude has uploaded a new change for review.

  https://gerrit.wikimedia.org/r/196011

Change subject: Remove auto width from edit toolbar in entitytermsview
......................................................................

Remove auto width from edit toolbar in entitytermsview

With this change, the edit links align to the left and
line up with the edit links in the statements section.

This gives a more consistent appearance. (in my opinion)

Bug: T89956
Change-Id: Ia1c7892b615da285e439eb5070c6af01ba19d168
---
M 
lib/resources/jquery.wikibase/themes/default/jquery.wikibase.entitytermsview.css
M 
lib/resources/jquery.wikibase/toolbar/controller/definitions/edittoolbar/entitytermsview.js
2 files changed, 4 insertions(+), 12 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/Wikibase 
refs/changes/11/196011/1

diff --git 
a/lib/resources/jquery.wikibase/themes/default/jquery.wikibase.entitytermsview.css
 
b/lib/resources/jquery.wikibase/themes/default/jquery.wikibase.entitytermsview.css
index 6bb0465..727ded5 100644
--- 
a/lib/resources/jquery.wikibase/themes/default/jquery.wikibase.entitytermsview.css
+++ 
b/lib/resources/jquery.wikibase/themes/default/jquery.wikibase.entitytermsview.css
@@ -9,6 +9,10 @@
        width: 100%;
 }
 
+.wikibase-entitytermsview .wikibase-entitytermsview-heading 
h1.wikibase-entitytermsview-heading-label {
+       padding-right: 11em;
+}
+
 .wikibase-entitytermsview .wikibase-entitytermsview-heading 
.wikibase-entitytermsview-heading-label 
.wikibase-entitytermsview-heading-label-id {
        color: grey;
        font-size: 0.6em;
@@ -63,11 +67,6 @@
 }
 .wikibase-entitytermsview 
.wikibase-entitytermsview-entitytermsforlanguagelistview-configure-hidden {
        display: none;
-}
-
-
-.wikibase-entitytermsview .wikibase-toolbar-container {
-       width: auto;
 }
 
 .wikibase-entitytermsview .wikibase-toolbar-container 
.wikibase-toolbar-container {
diff --git 
a/lib/resources/jquery.wikibase/toolbar/controller/definitions/edittoolbar/entitytermsview.js
 
b/lib/resources/jquery.wikibase/toolbar/controller/definitions/edittoolbar/entitytermsview.js
index 745c8a2..fda4a2f 100644
--- 
a/lib/resources/jquery.wikibase/toolbar/controller/definitions/edittoolbar/entitytermsview.js
+++ 
b/lib/resources/jquery.wikibase/toolbar/controller/definitions/edittoolbar/entitytermsview.js
@@ -29,14 +29,7 @@
                        $entitytermsview.data( 'edittoolbar' ).option( 
'$container' )
                        .sticknode( {
                                $container: 
entitytermsview.$entitytermsforlanguagelistview,
-                               autoWidth: true,
                                zIndex: 2
-                       } )
-                       .on( 'sticknodeupdate', function( event ) {
-                               if( !$( event.target ).data( 'sticknode' 
).isFixed() ) {
-                                       $entitytermsview.data( 'edittoolbar' )
-                                               .option( '$container' ).css( 
'width', 'auto' );
-                               }
                        } );
 
                        $entitytermsview.on( 'keyup.edittoolbar', function( 
event ) {

-- 
To view, visit https://gerrit.wikimedia.org/r/196011
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Ia1c7892b615da285e439eb5070c6af01ba19d168
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/Wikibase
Gerrit-Branch: master
Gerrit-Owner: Aude <aude.w...@gmail.com>

_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

Reply via email to