jenkins-bot has submitted this change and it was merged.
Change subject: Move direction applying to inner element
......................................................................
Move direction applying to inner element
On [[Q2]] badge of "ar" link is placed on left, badge is UI
stuff and should not be place on left just because the text
is RTL. Also if you be more percise every RTL language link
has extra space on left (on English UI), this is to fix it.
Change-Id: I66a982a88a3513d98278db64120c00c654fa682f
---
M lib/resources/jquery.wikibase/jquery.wikibase.sitelinkview.js
M repo/includes/View/SiteLinksView.php
M repo/resources/templates.php
3 files changed, 6 insertions(+), 4 deletions(-)
Approvals:
Thiemo Mättig (WMDE): Looks good to me, approved
jenkins-bot: Verified
diff --git a/lib/resources/jquery.wikibase/jquery.wikibase.sitelinkview.js
b/lib/resources/jquery.wikibase/jquery.wikibase.sitelinkview.js
index bd270ca..5deba41 100644
--- a/lib/resources/jquery.wikibase/jquery.wikibase.sitelinkview.js
+++ b/lib/resources/jquery.wikibase/jquery.wikibase.sitelinkview.js
@@ -178,7 +178,8 @@
siteLink ? site.getUrlTo(
siteLink.getPageName() ) : '',
siteLink ? siteLink.getPageName() : '',
mw.wbTemplate(
'wikibase-badgeselector', '' ),
- site ? site.getLanguageCode() : ''
+ site ? site.getLanguageCode() : '',
+ site ? site.getLanguageDirection() : ''
)
);
}
diff --git a/repo/includes/View/SiteLinksView.php
b/repo/includes/View/SiteLinksView.php
index e7d0aac..0625861 100644
--- a/repo/includes/View/SiteLinksView.php
+++ b/repo/includes/View/SiteLinksView.php
@@ -294,7 +294,8 @@
htmlspecialchars( $site->getPageUrl( $pageName ) ),
htmlspecialchars( $pageName ),
$this->getHtmlForBadges( $siteLink ),
- $site->getLanguageCode()
+ $site->getLanguageCode(),
+ 'auto'
);
}
diff --git a/repo/resources/templates.php b/repo/resources/templates.php
index ec9b17b..55c7835 100644
--- a/repo/resources/templates.php
+++ b/repo/resources/templates.php
@@ -242,13 +242,13 @@
<li class="wikibase-sitelinkview wikibase-sitelinkview-$1" data-wb-siteid="$1">
<span class="wikibase-sitelinkview-siteid-container">
<span class="wikibase-sitelinkview-siteid
wikibase-sitelinkview-siteid-$1" title="$5">$4</span>
- </span><span class="wikibase-sitelinkview-link
wikibase-sitelinkview-link-$1" lang="$2" dir="$3"><!--
wikibase-sitelinkview-pagename -->$6</span>
+ </span><span class="wikibase-sitelinkview-link
wikibase-sitelinkview-link-$1" lang="$2"><!-- wikibase-sitelinkview-pagename
-->$6</span>
</li>
HTML;
$templates['wikibase-sitelinkview-pagename'] =
<<<HTML
-<span class="wikibase-sitelinkview-page"><a href="$1"
hreflang="$4">$2</a></span>$3
+<span class="wikibase-sitelinkview-page" dir="$5"><a href="$1"
hreflang="$4">$2</a></span>$3
HTML;
$templates['wikibase-sitelinkview-unknown'] =
--
To view, visit https://gerrit.wikimedia.org/r/193803
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I66a982a88a3513d98278db64120c00c654fa682f
Gerrit-PatchSet: 3
Gerrit-Project: mediawiki/extensions/Wikibase
Gerrit-Branch: master
Gerrit-Owner: Ebrahim <ebra...@gnu.org>
Gerrit-Reviewer: Adrian Lang <adrian.he...@wikimedia.de>
Gerrit-Reviewer: Amire80 <amir.ahar...@mail.huji.ac.il>
Gerrit-Reviewer: Aude <aude.w...@gmail.com>
Gerrit-Reviewer: Ebrahim <ebra...@gnu.org>
Gerrit-Reviewer: Henning Snater <henning.sna...@wikimedia.de>
Gerrit-Reviewer: Jeroen De Dauw <jeroended...@gmail.com>
Gerrit-Reviewer: Nikerabbit <niklas.laxst...@gmail.com>
Gerrit-Reviewer: Siebrand <siebr...@kitano.nl>
Gerrit-Reviewer: Thiemo Mättig (WMDE) <thiemo.maet...@wikimedia.de>
Gerrit-Reviewer: jenkins-bot <>
_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
