Thiemo Mättig (WMDE) has uploaded a new change for review.
https://gerrit.wikimedia.org/r/196228
Change subject: Add fail-safe assertions to ClaimDifferTest
......................................................................
Add fail-safe assertions to ClaimDifferTest
Bug: T92487
Change-Id: I6c15e9b8c03a3b218cd32f3a2a569a45c49a735c
---
M repo/tests/phpunit/includes/Diff/ClaimDifferTest.php
1 file changed, 9 insertions(+), 0 deletions(-)
git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/Wikibase
refs/changes/28/196228/1
diff --git a/repo/tests/phpunit/includes/Diff/ClaimDifferTest.php
b/repo/tests/phpunit/includes/Diff/ClaimDifferTest.php
index 01c689f..dda418e 100644
--- a/repo/tests/phpunit/includes/Diff/ClaimDifferTest.php
+++ b/repo/tests/phpunit/includes/Diff/ClaimDifferTest.php
@@ -117,6 +117,15 @@
$actual = $differ->diffClaims( $oldClaim, $newClaim );
$this->assertTrue( $expected->equals( $actual ) );
+ // Additional fail-safe checks to guard against an ArrayObject
bug in PHP 5.3.
+ $this->assertEquals(
+ $expected->getQualifierChanges()->getArrayCopy(),
+ $actual->getQualifierChanges()->getArrayCopy()
+ );
+ $this->assertEquals(
+ $expected->getReferenceChanges()->getArrayCopy(),
+ $actual->getReferenceChanges()->getArrayCopy()
+ );
}
}
--
To view, visit https://gerrit.wikimedia.org/r/196228
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I6c15e9b8c03a3b218cd32f3a2a569a45c49a735c
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/Wikibase
Gerrit-Branch: master
Gerrit-Owner: Thiemo Mättig (WMDE) <thiemo.maet...@wikimedia.de>
_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
