Dbrant has uploaded a new change for review. https://gerrit.wikimedia.org/r/196285
Change subject: Fix list item background in 2.3. ...................................................................... Fix list item background in 2.3. Under 2.3, the list items (search results, history, etc) were showing up with a solid blue (selected) background. It looks like the state_activated property is having an effect on the background, even though it's not supposed to apply to 2.3. I've split off the list background selector for API 11+, and modified the one for API 10 to no longer have state_activated. Change-Id: Ie3e29c151f9989e8c23ace09a188a84d00f660ca --- A wikipedia/res/drawable-v11/selectable_item_background.xml M wikipedia/res/drawable/selectable_item_background.xml 2 files changed, 10 insertions(+), 3 deletions(-) git pull ssh://gerrit.wikimedia.org:29418/apps/android/wikipedia refs/changes/85/196285/1 diff --git a/wikipedia/res/drawable-v11/selectable_item_background.xml b/wikipedia/res/drawable-v11/selectable_item_background.xml new file mode 100644 index 0000000..76cdf58 --- /dev/null +++ b/wikipedia/res/drawable-v11/selectable_item_background.xml @@ -0,0 +1,9 @@ +<?xml version="1.0" encoding="utf-8"?> + +<selector xmlns:android="http://schemas.android.com/apk/res/android"; + android:exitFadeDuration="@android:integer/config_mediumAnimTime"> + <item android:state_activated="true" android:drawable="@color/list_item_selected" /> + <item android:state_checked="true" android:drawable="@color/list_item_selected" /> + <item android:state_pressed="true" android:drawable="@color/list_item_highlight" /> + <item android:drawable="@android:color/transparent" /> +</selector> \ No newline at end of file diff --git a/wikipedia/res/drawable/selectable_item_background.xml b/wikipedia/res/drawable/selectable_item_background.xml index 76cdf58..f2d0117 100644 --- a/wikipedia/res/drawable/selectable_item_background.xml +++ b/wikipedia/res/drawable/selectable_item_background.xml @@ -1,8 +1,6 @@ <?xml version="1.0" encoding="utf-8"?> -<selector xmlns:android="http://schemas.android.com/apk/res/android"; - android:exitFadeDuration="@android:integer/config_mediumAnimTime"> - <item android:state_activated="true" android:drawable="@color/list_item_selected" /> +<selector xmlns:android="http://schemas.android.com/apk/res/android";> <item android:state_checked="true" android:drawable="@color/list_item_selected" /> <item android:state_pressed="true" android:drawable="@color/list_item_highlight" /> <item android:drawable="@android:color/transparent" /> -- To view, visit https://gerrit.wikimedia.org/r/196285 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: newchange Gerrit-Change-Id: Ie3e29c151f9989e8c23ace09a188a84d00f660ca Gerrit-PatchSet: 1 Gerrit-Project: apps/android/wikipedia Gerrit-Branch: master Gerrit-Owner: Dbrant <dbr...@wikimedia.org> _______________________________________________ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
