jenkins-bot has submitted this change and it was merged. Change subject: Fix list selection on watchstar overlay ......................................................................
Fix list selection on watchstar overlay Event handler was accessing target which could be the icon when what it wanted was always the 'li' element (currentTarget instead of target or delegateTarget) http://api.jquery.com/event.currentTarget/ Bug: T92350 Change-Id: I6a3e52062df20527c0eab3306a0568514c37a326 --- M resources/ext.gather.watchstar/CollectionsContentOverlay.js 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Jdlrobson: Looks good to me, approved jenkins-bot: Verified diff --git a/resources/ext.gather.watchstar/CollectionsContentOverlay.js b/resources/ext.gather.watchstar/CollectionsContentOverlay.js index 926b3e4..6b1e155 100644 --- a/resources/ext.gather.watchstar/CollectionsContentOverlay.js +++ b/resources/ext.gather.watchstar/CollectionsContentOverlay.js @@ -101,7 +101,7 @@ */ onSelectCollection: function ( ev ) { var collection, - $target = $( ev.target ), + $target = $( ev.currentTarget ), page = M.getCurrentPage(); collection = { -- To view, visit https://gerrit.wikimedia.org/r/196267 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: merged Gerrit-Change-Id: I6a3e52062df20527c0eab3306a0568514c37a326 Gerrit-PatchSet: 1 Gerrit-Project: mediawiki/extensions/Gather Gerrit-Branch: master Gerrit-Owner: Jhernandez <jhernan...@wikimedia.org> Gerrit-Reviewer: Jdlrobson <jrob...@wikimedia.org> Gerrit-Reviewer: jenkins-bot <> _______________________________________________ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
