Jdouglas has uploaded a new change for review. https://gerrit.wikimedia.org/r/196301
Change subject: Dump the query when 'cirrusDumpQuery' is requested ...................................................................... Dump the query when 'cirrusDumpQuery' is requested Currently we dump the Cirrus query when 'cirrusDumpQuery=yes' is requested, but requiring the parameter to be 'yes' is rather silly. This change triggers the query dump when the parameter is requested, regardless of its value. That means it can have any value, or no value at all: * ...&cirrusDumpQuery=yes * ...&cirrusDumpQuery=true * ...&cirrusDumpQuery=yep * ...&cirrusDumpQuery=1 * ...&cirrusDumpQuery Change-Id: I026c1ac28891a95de80764d5629ebcc3c9790a85 --- M includes/CirrusSearch.php 1 file changed, 1 insertion(+), 1 deletion(-) git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/CirrusSearch refs/changes/01/196301/1 diff --git a/includes/CirrusSearch.php b/includes/CirrusSearch.php index 418a43a..58ac7f6 100644 --- a/includes/CirrusSearch.php +++ b/includes/CirrusSearch.php @@ -92,7 +92,7 @@ } $request = $context->getRequest(); - $dumpQuery = $request && $request->getVal( 'cirrusDumpQuery' ) === 'yes'; + $dumpQuery = $request && $request->getVal( 'cirrusDumpQuery' ) !== null; $searcher->setReturnQuery( $dumpQuery ); // Delegate to either searchText or moreLikeThisArticle and dump the result into $status if ( substr( $term, 0, strlen( self::MORE_LIKE_THIS_PREFIX ) ) === self::MORE_LIKE_THIS_PREFIX ) { -- To view, visit https://gerrit.wikimedia.org/r/196301 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I026c1ac28891a95de80764d5629ebcc3c9790a85 Gerrit-PatchSet: 1 Gerrit-Project: mediawiki/extensions/CirrusSearch Gerrit-Branch: master Gerrit-Owner: Jdouglas <jdoug...@wikimedia.org> _______________________________________________ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits