Bmansurov has uploaded a new change for review. https://gerrit.wikimedia.org/r/196412
Change subject: Fix closing the media viewer ...................................................................... Fix closing the media viewer Properly inherit Overlay events and defaults Bug: T92346 Change-Id: I2880d070b0de04928f40320536b02a483d2c2681 --- M javascripts/modules/mediaViewer/ImageOverlay.js 1 file changed, 4 insertions(+), 4 deletions(-) git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/MobileFrontend refs/changes/12/196412/1 diff --git a/javascripts/modules/mediaViewer/ImageOverlay.js b/javascripts/modules/mediaViewer/ImageOverlay.js index f33dd23..733899e 100644 --- a/javascripts/modules/mediaViewer/ImageOverlay.js +++ b/javascripts/modules/mediaViewer/ImageOverlay.js @@ -28,7 +28,7 @@ * @cfg {String} defaults.licenseLinkMsg Link to license information in media viewer. * @cfg {Thumbnail[]} defaults.thumbnails a list of thumbnails to browse */ - defaults: { + defaults: $.extend( {}, Overlay.prototype.defaults, { cancelButton: new Icon( { tagName: 'button', // Uses a dark theme so swap out the icon @@ -39,12 +39,12 @@ detailsMsg: mw.msg( 'mobile-frontend-media-details' ), licenseLinkMsg: mw.msg( 'mobile-frontend-media-license-link' ), thumbnails: [] - }, + } ), /** @inheritdoc */ - events: { + events: $.extend( {}, Overlay.prototype.events, { 'click .image-wrapper': 'onToggleDetails' - }, + } ), /** @inheritdoc */ preRender: function ( options ) { -- To view, visit https://gerrit.wikimedia.org/r/196412 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I2880d070b0de04928f40320536b02a483d2c2681 Gerrit-PatchSet: 1 Gerrit-Project: mediawiki/extensions/MobileFrontend Gerrit-Branch: master Gerrit-Owner: Bmansurov <bmansu...@wikimedia.org> _______________________________________________ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits