jenkins-bot has submitted this change and it was merged. Change subject: Pass if log entry is legacy to ApiQueryLogEvents::addLogParams() ......................................................................
Pass if log entry is legacy to ApiQueryLogEvents::addLogParams() Querying via ApiQueryRecentChanges and ApiQueryWatchlist did not pass if a particular log entry was a legacy log entry. Ultimately CheckUser should stop writing legacy style log entries too but we can at least behave properly when we hit them. Bug: T91466 Change-Id: I1564ec7e599e2f9d78775e63e06eca84db497a43 (cherry picked from commit cc2eb92668cd731594fa7b3025768c533c7846f4) --- M includes/api/ApiQueryRecentChanges.php M includes/api/ApiQueryWatchlist.php 2 files changed, 4 insertions(+), 2 deletions(-) Approvals: Alex Monk: Looks good to me, approved jenkins-bot: Verified diff --git a/includes/api/ApiQueryRecentChanges.php b/includes/api/ApiQueryRecentChanges.php index 1482034..aa22264 100644 --- a/includes/api/ApiQueryRecentChanges.php +++ b/includes/api/ApiQueryRecentChanges.php @@ -542,7 +542,8 @@ $logEntry->getParameters(), $logEntry->getType(), $logEntry->getSubtype(), - $logEntry->getTimestamp() + $logEntry->getTimestamp(), + $logEntry->isLegacy() ); } } diff --git a/includes/api/ApiQueryWatchlist.php b/includes/api/ApiQueryWatchlist.php index 11008cf..3857a08 100644 --- a/includes/api/ApiQueryWatchlist.php +++ b/includes/api/ApiQueryWatchlist.php @@ -419,7 +419,8 @@ $logEntry->getParameters(), $logEntry->getType(), $logEntry->getSubtype(), - $logEntry->getTimestamp() + $logEntry->getTimestamp(), + $logEntry->isLegacy() ); } } -- To view, visit https://gerrit.wikimedia.org/r/196317 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: merged Gerrit-Change-Id: I1564ec7e599e2f9d78775e63e06eca84db497a43 Gerrit-PatchSet: 1 Gerrit-Project: mediawiki/core Gerrit-Branch: wmf/1.25wmf20 Gerrit-Owner: Alex Monk <kren...@gmail.com> Gerrit-Reviewer: Alex Monk <kren...@gmail.com> Gerrit-Reviewer: Anomie <bjor...@wikimedia.org> Gerrit-Reviewer: Chad <ch...@wikimedia.org> Gerrit-Reviewer: jenkins-bot <> _______________________________________________ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits