Subramanya Sastry has uploaded a new change for review.
https://gerrit.wikimedia.org/r/196703
Change subject: Fix another instance of non-reusable orig-src in edited lists
......................................................................
Fix another instance of non-reusable orig-src in edited lists
* In both tests below, editing the second or later list items
causes selser to lose the list prefix for the first list item.
* This patch bars reuse of orig src for the first list item
of a nested list.
* Adding manual selser tests in these scenarios requires the patch
for T72722 to be merged.
------
------
;a
:*x
:*y
------
Change-Id: Ic4e8728a9526b0e1a052bd1a5507a98a6a4c100b
---
M lib/mediawiki.WikitextSerializer.js
1 file changed, 9 insertions(+), 0 deletions(-)
git pull ssh://gerrit.wikimedia.org:29418/mediawiki/services/parsoid
refs/changes/03/196703/1
diff --git a/lib/mediawiki.WikitextSerializer.js
b/lib/mediawiki.WikitextSerializer.js
index f20bc01..b100e80 100644
--- a/lib/mediawiki.WikitextSerializer.js
+++ b/lib/mediawiki.WikitextSerializer.js
@@ -930,6 +930,15 @@
}
return true;
+ } else if ( DU.isListItem(node) ) {
+ // If a list-item is the first child of a nested list, we
cannot reuse
+ // the source for the list item.
+ var list = node.parentNode;
+ if ((DU.firstNonSepChildNode(list) === node) &&
DU.isListItem(list.parentNode)) {
+ return false;
+ } else {
+ return true;
+ }
} else {
return true;
}
--
To view, visit https://gerrit.wikimedia.org/r/196703
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ic4e8728a9526b0e1a052bd1a5507a98a6a4c100b
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/services/parsoid
Gerrit-Branch: master
Gerrit-Owner: Subramanya Sastry <ssas...@wikimedia.org>
_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
