jenkins-bot has submitted this change and it was merged.
Change subject: renderer.article: Don't apply tall/not-tall classes if the
image wasn't shown
......................................................................
renderer.article: Don't apply tall/not-tall classes if the image wasn't shown
Bug: T91433
Change-Id: I4499cc18e140c0bd18ee3731496aa427232922b4
---
M resources/ext.popups.renderer.article.js
1 file changed, 1 insertion(+), 1 deletion(-)
Approvals:
Werdna: Looks good to me, approved
jenkins-bot: Verified
diff --git a/resources/ext.popups.renderer.article.js
b/resources/ext.popups.renderer.article.js
index e31dbb2..46d3e62 100644
--- a/resources/ext.popups.renderer.article.js
+++ b/resources/ext.popups.renderer.article.js
@@ -127,7 +127,7 @@
.attr( 'href', href )
.append( $thumbnail );
} else {
- thumbnail = undefined;
+ tall = thumbnail = undefined;
}
$div = $( '<div>' ).append( $thumbnail, $contentbox, $timestamp
);
--
To view, visit https://gerrit.wikimedia.org/r/194464
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I4499cc18e140c0bd18ee3731496aa427232922b4
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/Popups
Gerrit-Branch: master
Gerrit-Owner: Prtksxna <psax...@wikimedia.org>
Gerrit-Reviewer: AndyRussG <andrew.green...@gmail.com>
Gerrit-Reviewer: Ricordisamoa <ricordisa...@openmailbox.org>
Gerrit-Reviewer: Werdna <agarr...@wikimedia.org>
Gerrit-Reviewer: jenkins-bot <>
_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
