[MediaWiki-commits] [Gerrit] References: Fix javascript error by infinite recursion - change (mediawiki...ContentTranslation)

[Santhosh (Code Review)]

Santhosh has uploaded a new change for review.

  https://gerrit.wikimedia.org/r/197286

Change subject: References: Fix javascript error by infinite recursion
......................................................................

References: Fix javascript error by infinite recursion

Bug: T92936
Change-Id: I8de0e7758fb06aae1d4e47ad4697fca82ea50e5d
---
M modules/tools/ext.cx.tools.reference.js
1 file changed, 8 insertions(+), 11 deletions(-)


  git pull 
ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/ContentTranslation 
refs/changes/86/197286/1

diff --git a/modules/tools/ext.cx.tools.reference.js 
b/modules/tools/ext.cx.tools.reference.js
index d9a23ae..13b34fc 100644
--- a/modules/tools/ext.cx.tools.reference.js
+++ b/modules/tools/ext.cx.tools.reference.js
@@ -189,7 +189,7 @@
         * @return {Object|null}
         */
        ReferenceCard.prototype.getReferenceData = function ( referenceId ) {
-               var $sourceReference, i, mwData, $referenceSiblings;
+               var $sourceReference, i, mwData, $sibling, $referenceSiblings, 
id;
 
                $sourceReference = $( document.getElementById( referenceId ) );
                if ( !$sourceReference.is( '[typeof*="mw:Extension/ref"]' ) ) {
@@ -197,19 +197,16 @@
                        return null;
                }
 
-               mwData = $sourceReference.data( 'mw' );
-               if ( mwData && mwData.body ) {
-                       return mwData;
-               }
-
                $referenceSiblings = $( '[typeof*="mw:Extension/references"]' )
                        .find( 'a[href="#' + referenceId + '"]' )
-                       .siblings();
+                       .siblings()
+                       .addBack(); // Including self
+
                for ( i = 0; i < $referenceSiblings.length; i++ ) {
-                       mwData = this.getReferenceData(
-                               $( $referenceSiblings[ i ] ).attr( 'href' 
).replace( '#', '' )
-                       );
-                       if ( mwData ) {
+                       id = $( $referenceSiblings[ i ] ).attr( 'href' 
).replace( '#', '' );
+                       $sibling = $( document.getElementById( id ) );
+                       mwData = $sibling.data( 'mw' );
+                       if ( mwData && mwData.body ) {
                                return mwData;
                        }
                }

-- 
To view, visit https://gerrit.wikimedia.org/r/197286
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I8de0e7758fb06aae1d4e47ad4697fca82ea50e5d
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/ContentTranslation
Gerrit-Branch: master
Gerrit-Owner: Santhosh <santhosh.thottin...@gmail.com>

_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits