Jeroen De Dauw has submitted this change and it was merged.
Change subject: Drop unused Summary::toString method
......................................................................
Drop unused Summary::toString method
Note that this is not the magic __toString method but an own. Nobody
calls it, so why have it in the first place?
Change-Id: If2a1438dc37ca4edf20483fba9afec5bd7f09ecc
---
M lib/includes/Summary.php
1 file changed, 0 insertions(+), 10 deletions(-)
Approvals:
Jeroen De Dauw: Looks good to me, approved
diff --git a/lib/includes/Summary.php b/lib/includes/Summary.php
index ab32b9b..4ceeb8a 100644
--- a/lib/includes/Summary.php
+++ b/lib/includes/Summary.php
@@ -2,8 +2,6 @@
namespace Wikibase;
-use LogicException;
-
/**
* A Summary object can be used to build complex, translatable summaries.
*
@@ -227,14 +225,6 @@
*/
public function getAutoSummaryArgs() {
return $this->summaryArgs;
- }
-
- /**
- * @deprecated Use SummaryFormatter instead
- * @throws LogicException
- */
- public function toString() {
- throw new LogicException( 'toString() is no longer supported,
use SummaryFormatter instead' );
}
}
--
To view, visit https://gerrit.wikimedia.org/r/191606
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: If2a1438dc37ca4edf20483fba9afec5bd7f09ecc
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/Wikibase
Gerrit-Branch: master
Gerrit-Owner: Thiemo Mättig (WMDE) <[email protected]>
Gerrit-Reviewer: Jeroen De Dauw <[email protected]>
Gerrit-Reviewer: jenkins-bot <>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
