Mforns has uploaded a new change for review.

  https://gerrit.wikimedia.org/r/197319

Change subject: Make row assignable
......................................................................

Make row assignable

The code was trying to assign to an item in row.
But row was a tuple, as returned by the database
wrapper. This change transforms the row into an
assignable list.

Bug: T89251
Change-Id: I560c86c680c445778c773b5a2ade26b98cdd5d0f
---
M reportupdater/executor.py
1 file changed, 1 insertion(+), 0 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/analytics/limn-mobile-data 
refs/changes/19/197319/1

diff --git a/reportupdater/executor.py b/reportupdater/executor.py
index 06e7a4d..b7ee594 100644
--- a/reportupdater/executor.py
+++ b/reportupdater/executor.py
@@ -121,6 +121,7 @@
             if not isinstance(sql_date, date):
                 raise ValueError('Query results do not have date values in 
first column.')
             # normalize to datetime
+            row = list(row)  # make row item assignable
             row[0] = datetime(sql_date.year, sql_date.month, sql_date.day, 0, 
0, 0, 0)
             if is_funnel:
                 data[row[0]].append(row)

-- 
To view, visit https://gerrit.wikimedia.org/r/197319
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I560c86c680c445778c773b5a2ade26b98cdd5d0f
Gerrit-PatchSet: 1
Gerrit-Project: analytics/limn-mobile-data
Gerrit-Branch: master
Gerrit-Owner: Mforns <[email protected]>

_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

Reply via email to