Prtksxna has uploaded a new change for review.
https://gerrit.wikimedia.org/r/197502
Change subject: Add link to talk page
......................................................................
Add link to talk page
Change-Id: I196eb8780ed6dd1639c1c507a493b780152eed64
---
M resources/master.less
M resources/talk.svg
M templates/Skin.php
M templates/sidebar.template
4 files changed, 25 insertions(+), 3 deletions(-)
git pull ssh://gerrit.wikimedia.org:29418/mediawiki/skins/LivingStyleGuide
refs/changes/02/197502/1
diff --git a/resources/master.less b/resources/master.less
index 593b1b6..42e7b9f 100644
--- a/resources/master.less
+++ b/resources/master.less
@@ -153,6 +153,10 @@
#ca-history {
background-image: url(history.svg);
}
+
+ #ca-talk {
+ background-image: url(talk.svg);
+ }
}
}
}
diff --git a/resources/talk.svg b/resources/talk.svg
index 19f5fcc..d447346 100644
--- a/resources/talk.svg
+++ b/resources/talk.svg
@@ -4,7 +4,7 @@
<svg version="1.1" id="Layer_1" xmlns="http://www.w3.org/2000/svg";
xmlns:xlink="http://www.w3.org/1999/xlink"; x="0px" y="0px"
width="24px" height="24px" viewBox="0 0 24 24" enable-background="new
0 0 24 24" xml:space="preserve">
<g transform="matrix(1 0 0 -1 0 1638)">
- <path
d="M7.957,1629.797h12.492v-8.555l2.18-2.438H9.34c-0.641,0-1.066,0.289-1.277,0.867c-0.07,0.195-0.105,0.367-0.105,0.516
+ <path fill="#fff"
d="M7.957,1629.797h12.492v-8.555l2.18-2.438H9.34c-0.641,0-1.066,0.289-1.277,0.867c-0.07,0.195-0.105,0.367-0.105,0.516
V1629.797z
M2.695,1634.473h12.516v-3.574H6.844v-7.418h-6.34l2.191,2.449V1634.473z"/>
</g>
</svg>
diff --git a/templates/Skin.php b/templates/Skin.php
index 4a70dea..90c488c 100644
--- a/templates/Skin.php
+++ b/templates/Skin.php
@@ -205,7 +205,16 @@
'.htmlentities((string)$cx['funcs']['v']($cx, $in, array('text')), ENT_QUOTES,
'UTF-8').'
</a>
</li>
-';}).'
+';}).' <li>
+ <a
+
href="'.htmlentities((string)$cx['funcs']['v']($cx, $in,
array('content_navigation','namespaces','talk','href')), ENT_QUOTES, 'UTF-8').'"
+
class="'.htmlentities((string)$cx['funcs']['v']($cx, $in,
array('content_navigation','namespaces','talk','class')), ENT_QUOTES,
'UTF-8').'"
+
id="'.htmlentities((string)$cx['funcs']['v']($cx, $in,
array('content_navigation','namespaces','talk','id')), ENT_QUOTES, 'UTF-8').'"
+ >
+ '.htmlentities((string)$cx['funcs']['v']($cx,
$in, array('content_navigation','namespaces','talk','text')), ENT_QUOTES,
'UTF-8').'
+ </a>
+
+ </li>
</ul>
<h2 id="navigation-header">Navigation</h2>
@@ -241,7 +250,7 @@
</div>
<ul class="nav navbar-nav navbar-right">
- <li><a href="#">Desktop</a></li>
+ <li><a rhref="#">Desktop</a></li>
<li><a href="#">Mobile</a></li>
</ul>
</nav>
diff --git a/templates/sidebar.template b/templates/sidebar.template
index 18ddd5f..d80925e 100644
--- a/templates/sidebar.template
+++ b/templates/sidebar.template
@@ -12,7 +12,16 @@
</a>
</li>
{{/each}}
+ <li>
+ <a
+ href="{{content_navigation.namespaces.talk.href}}"
+ class="{{content_navigation.namespaces.talk.class}}"
+ id="{{content_navigation.namespaces.talk.id}}"
+ >
+ {{content_navigation.namespaces.talk.text}}
+ </a>
+ </li>
</ul>
<h2 id="navigation-header">Navigation</h2>
--
To view, visit https://gerrit.wikimedia.org/r/197502
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I196eb8780ed6dd1639c1c507a493b780152eed64
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/skins/LivingStyleGuide
Gerrit-Branch: master
Gerrit-Owner: Prtksxna <[email protected]>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
