Trevor Parscal has uploaded a new change for review. https://gerrit.wikimedia.org/r/197700
Change subject: Avoid miscalculation of monospace text height ...................................................................... Avoid miscalculation of monospace text height By increasing line height we can avoid this browser inconsistency. I treid to recreate it in isolation, but it doesn't seem to have the exact same issues in all browsers. Nonetheless this jsFiddle does appear to show the problem in Chrome on a Mac. http://jsfiddle.net/zgjgmw82/ Bug: T92450 Change-Id: Iede339563852addebcac0c0957d8c33926c24add --- M src/ui/styles/contextitems/ve.ui.CommentContextItem.css 1 file changed, 1 insertion(+), 1 deletion(-) git pull ssh://gerrit.wikimedia.org:29418/VisualEditor/VisualEditor refs/changes/00/197700/1 diff --git a/src/ui/styles/contextitems/ve.ui.CommentContextItem.css b/src/ui/styles/contextitems/ve.ui.CommentContextItem.css index 04eb263..39fa101 100644 --- a/src/ui/styles/contextitems/ve.ui.CommentContextItem.css +++ b/src/ui/styles/contextitems/ve.ui.CommentContextItem.css @@ -11,6 +11,6 @@ max-height: 10em; font-family: 'Courier New', 'Courier', monospace; white-space: pre-wrap; - line-height: 1em; + line-height: 1.25em; color: #555; } -- To view, visit https://gerrit.wikimedia.org/r/197700 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: newchange Gerrit-Change-Id: Iede339563852addebcac0c0957d8c33926c24add Gerrit-PatchSet: 1 Gerrit-Project: VisualEditor/VisualEditor Gerrit-Branch: master Gerrit-Owner: Trevor Parscal <[email protected]> _______________________________________________ MediaWiki-commits mailing list [email protected] https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
